You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "yzang2019 (via GitHub)" <gi...@apache.org> on 2023/06/09 18:44:41 UTC
[GitHub] [flink] yzang2019 opened a new pull request, #22754: [FLINK-32305] [History Server] Add number of workers to parallelize archive processing
yzang2019 opened a new pull request, #22754:
URL: https://github.com/apache/flink/pull/22754
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Problem:
Currently, if we have hundreds or thousands of history jobs sitting in HDFS, everytime when we restart or redeploy history server, it will take 30 minutes or up to hours to show some data on the web page. During this time, the history server is loading all the history job metadata from HDFS to build local webviews, however the web page is not usable since there's no content showing up until all jobs are done for the first round.
Goal:
This PR is aiming to
- Improve the time and speed of displaying history completed jobs on startup
- Improve the performance of history server processing a single job by adding parallelism
- Improve the overall user experience of history server
## Brief change log
- Add a new configuration for history server to set the number of workers for parallelizm
- Optimized the logic for history server webview update:
Before: Update the webview only after we finish processing ALL job achieves
After: Update the webview each time we finish processing a new job archive
## Verifying this change
- Added corresponding unit test for verify the new configuration.
- Modified existing unit test to cover multi-threaded scenario.
- Manually did integration test and canary in Twitter's environment with hundreds of job history
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yzang2019 commented on pull request #22754: [FLINK-32305] [History Server] Add number of workers to parallelize job archive processing
Posted by "yzang2019 (via GitHub)" <gi...@apache.org>.
yzang2019 commented on PR #22754:
URL: https://github.com/apache/flink/pull/22754#issuecomment-1585249703
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yzang2019 commented on pull request #22754: [FLINK-32305] [History Server] Add number of workers to parallelize job archive processing
Posted by "yzang2019 (via GitHub)" <gi...@apache.org>.
yzang2019 commented on PR #22754:
URL: https://github.com/apache/flink/pull/22754#issuecomment-1588247950
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yzang2019 commented on pull request #22754: [FLINK-32305] [History Server] Add number of workers to parallelize job archive processing
Posted by "yzang2019 (via GitHub)" <gi...@apache.org>.
yzang2019 commented on PR #22754:
URL: https://github.com/apache/flink/pull/22754#issuecomment-1587456200
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #22754: [FLINK-32305] [History Server] Add number of workers to parallelize archive processing
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22754:
URL: https://github.com/apache/flink/pull/22754#issuecomment-1585003869
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ab9f6d8be388ccb2f4df650685e82dd0ec910da1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ab9f6d8be388ccb2f4df650685e82dd0ec910da1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ab9f6d8be388ccb2f4df650685e82dd0ec910da1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yzang2019 commented on pull request #22754: [FLINK-32305] [History Server] Add number of workers to parallelize job archive processing
Posted by "yzang2019 (via GitHub)" <gi...@apache.org>.
yzang2019 commented on PR #22754:
URL: https://github.com/apache/flink/pull/22754#issuecomment-1587705517
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yzang2019 commented on pull request #22754: [FLINK-32305] [History Server] Add number of workers to parallelize job archive processing
Posted by "yzang2019 (via GitHub)" <gi...@apache.org>.
yzang2019 commented on PR #22754:
URL: https://github.com/apache/flink/pull/22754#issuecomment-1587561937
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yzang2019 commented on pull request #22754: [FLINK-32305] [History Server] Add number of workers to parallelize job archive processing
Posted by "yzang2019 (via GitHub)" <gi...@apache.org>.
yzang2019 commented on PR #22754:
URL: https://github.com/apache/flink/pull/22754#issuecomment-1589181636
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yzang2019 commented on pull request #22754: [FLINK-32305] [History Server] Add number of workers to parallelize job archive processing
Posted by "yzang2019 (via GitHub)" <gi...@apache.org>.
yzang2019 commented on PR #22754:
URL: https://github.com/apache/flink/pull/22754#issuecomment-1587656476
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-32305] [History Server] Add number of workers to parallelize job archive processing [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22754:
URL: https://github.com/apache/flink/pull/22754#issuecomment-2595358912
This PR is being marked as stale since it has not had any activity in the last 180 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.
If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 90 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-32305] [History Server] Add number of workers to parallelize job archive processing [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22754:
URL: https://github.com/apache/flink/pull/22754#issuecomment-2774618745
This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-32305] [History Server] Add number of workers to parallelize job archive processing [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #22754: [FLINK-32305] [History Server] Add number of workers to parallelize job archive processing
URL: https://github.com/apache/flink/pull/22754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yzang2019 commented on pull request #22754: [FLINK-32305] [History Server] Add number of workers to parallelize job archive processing
Posted by "yzang2019 (via GitHub)" <gi...@apache.org>.
yzang2019 commented on PR #22754:
URL: https://github.com/apache/flink/pull/22754#issuecomment-1585186980
@flinkbot run azure
> ## CI report:
> * [ab9f6d8](https://github.com/apache/flink/commit/ab9f6d8be388ccb2f4df650685e82dd0ec910da1) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=49860)
> * [d076695](https://github.com/apache/flink/commit/d076695b4fca7de5d323dddf7930e73173e63b8f) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=49861)
>
> Bot commands
> The @flinkbot bot supports the following commands:
> * `@flinkbot run azure` re-run the last Azure build
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yzang2019 commented on pull request #22754: [FLINK-32305] [History Server] Add number of workers to parallelize job archive processing
Posted by "yzang2019 (via GitHub)" <gi...@apache.org>.
yzang2019 commented on PR #22754:
URL: https://github.com/apache/flink/pull/22754#issuecomment-1588298923
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org