You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/16 15:18:35 UTC

[GitHub] dongjoon-hyun commented on a change in pull request #23804: [WIP][SPARK-26896] JDK 11 module adjustments for running tests

dongjoon-hyun commented on a change in pull request #23804: [WIP][SPARK-26896] JDK 11 module adjustments for running tests
URL: https://github.com/apache/spark/pull/23804#discussion_r257464391
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -2117,7 +2119,7 @@
               <include>**/*Suite.java</include>
             </includes>
             <reportsDirectory>${project.build.directory}/surefire-reports</reportsDirectory>
-            <argLine>-ea -Xmx4g -Xss4m -XX:ReservedCodeCacheSize=${CodeCacheSize}</argLine>
+            <argLine>-ea -Xmx3g -Xss4m -XX:ReservedCodeCacheSize=${CodeCacheSize} ${jdk11.module.args}</argLine>
 
 Review comment:
   Hi, @squito . Do we need to reduce this back to `3g` for JDK11?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org