You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Thiago Henrique De Paula Figueiredo (Jira)" <ji...@apache.org> on 2022/03/28 13:07:00 UTC

[jira] [Updated] (TAP5-2712) Error component renders unstyled with Bootstrap 4

     [ https://issues.apache.org/jira/browse/TAP5-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thiago Henrique De Paula Figueiredo updated TAP5-2712:
------------------------------------------------------
    Description: 
As noticed and solved by [~vlamp] in the Tapestry dev mailing list:
{quote}Using Tapestry's BeanEditor component with Bootstrap 4, I'm trying to get
validation error messages appear with a red font color like they used to
with Bootstrap 3.

Trying to understand from the Tapestry source code why Tapestry outputs
Bootstrap v3-style "help-block" instead of v4-style "form-text" [1], I
became aware of the SymbolConstants.ERROR_CSS_CLASS configuration symbol.
Setting its value to "form-text text-danger" did the trick for me.

Two recommendations for improvement:

First, the Configuration page of the Tapestry website [2] doesn't mention
the ERROR_CSS_CLASS configuration symbol. It should be added to make it
easier for other Tapestry users trying to solve the same problem or similar
problems.

Second, importing the Bootstrap4Module should provide validation messages
with a red font color as the default.
{quote}

  was:
As noticed by [~vlamp] in the Tapestry dev mailing list:
{quote}Using Tapestry's BeanEditor component with Bootstrap 4, I'm trying to get
validation error messages appear with a red font color like they used to
with Bootstrap 3.

Trying to understand from the Tapestry source code why Tapestry outputs
Bootstrap v3-style "help-block" instead of v4-style "form-text" [1], I
became aware of the SymbolConstants.ERROR_CSS_CLASS configuration symbol.
Setting its value to "form-text text-danger" did the trick for me.

Two recommendations for improvement:

First, the Configuration page of the Tapestry website [2] doesn't mention
the ERROR_CSS_CLASS configuration symbol. It should be added to make it
easier for other Tapestry users trying to solve the same problem or similar
problems.

Second, importing  the Bootstrap4Module should provide validation messages
with a red font color as the default.{quote}


> Error component renders unstyled with Bootstrap 4
> -------------------------------------------------
>
>                 Key: TAP5-2712
>                 URL: https://issues.apache.org/jira/browse/TAP5-2712
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.5.0, 5.6.0, 5.6.1, 5.6.2, 5.7.0, 5.6.3, 5.7.1, 5.7.2, 5.6.4, 5.7.3, 5.8.0
>            Reporter: Thiago Henrique De Paula Figueiredo
>            Priority: Major
>
> As noticed and solved by [~vlamp] in the Tapestry dev mailing list:
> {quote}Using Tapestry's BeanEditor component with Bootstrap 4, I'm trying to get
> validation error messages appear with a red font color like they used to
> with Bootstrap 3.
> Trying to understand from the Tapestry source code why Tapestry outputs
> Bootstrap v3-style "help-block" instead of v4-style "form-text" [1], I
> became aware of the SymbolConstants.ERROR_CSS_CLASS configuration symbol.
> Setting its value to "form-text text-danger" did the trick for me.
> Two recommendations for improvement:
> First, the Configuration page of the Tapestry website [2] doesn't mention
> the ERROR_CSS_CLASS configuration symbol. It should be added to make it
> easier for other Tapestry users trying to solve the same problem or similar
> problems.
> Second, importing the Bootstrap4Module should provide validation messages
> with a red font color as the default.
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)