[GitHub] [druid] maytasm3 commented on issue #9375: Add support for optional cloud (aws, gcs, etc.) credentials for s3 for ingestion

[GitBox <gi...@apache.org>]

maytasm3 commented on issue #9375: Add support for optional cloud (aws, gcs, etc.) credentials for s3 for ingestion
URL: https://github.com/apache/druid/pull/9375#issuecomment-590220287
 
 
   @clintropolis 
   Addressed comments. Please review again when you have time.
   Main changes:
   - Made specific s3ConfigProperties class for S3 without sharing inheritance (hence, removed CloudConfigProperties).
   - Added s3ConfigProperties to the constructor for S3InputSource in the withSplit method (so that the peons can connect to s3 using the s3ConfigProperties from main worker)
   - Made s3Client lazy initialize inside the S3InputSource
   - Update docs  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org