You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by smarthi <gi...@git.apache.org> on 2015/11/16 23:02:26 UTC

[GitHub] flink pull request: Change the parameter 'numSample' in DataSetUti...

GitHub user smarthi opened a pull request:

    https://github.com/apache/flink/pull/1362

    Change the parameter 'numSample' in DataSetUtils.sampleWithSize() to …

    …'numSamples', and remove redundant Java 6 code

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/smarthi/flink Nitpick

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1362.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1362
    
----
commit af3e5704fd925cca7a6303687c294aba5f46528d
Author: smarthi <sm...@apache.org>
Date:   2015-11-16T22:00:30Z

    Change the parameter 'numSample' in DataSetUtils.sampleWithSize() to 'numSamples', remove redundant Java 6 code

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: Change the parameter 'numSample' in DataSetUti...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1362


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: Change the parameter 'numSample' in DataSetUti...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1362#issuecomment-157342698
  
    Looks good, will merge this...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: Change the parameter 'numSample' in DataSetUti...

Posted by smarthi <gi...@git.apache.org>.

Github user smarthi commented on the pull request:

    https://github.com/apache/flink/pull/1362#issuecomment-157309957
  
    @tillrohrmann this is the nitpick PR we talked about


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---