You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/27 02:51:52 UTC

[GitHub] [spark] itholic opened a new pull request #34397: [SPARK-36348][PYTHON][FOLLOWUP] Complete test_astype for index

itholic opened a new pull request #34397:
URL: https://github.com/apache/spark/pull/34397


   ### What changes were proposed in this pull request?
   
   This is follow-up for https://github.com/apache/spark/pull/34335.
   
   
   ### Why are the changes needed?
   
   The previous bug depends on the pandas version, not the Spark version.
   
   So the difference is still alive with pandas < 1.3.
   
   For example,
   
   ```python
   # Spark 3.2 with pandas 1.2.
   >>> pidx = pd.Index([10, 20, 15, 30, 45, None], name="x")
   >>> psidx = ps.Index(pidx)
   
   >>> pidx
   Index([10, 20, 15, 30, 45, None], dtype='object', name='x')
   >>> psidx
   Float64Index([10.0, 20.0, 15.0, 30.0, 45.0, nan], dtype='float64', name='x')
   
   >>> pidx.astype(str)
   Index(['10', '20', '15', '30', '45', 'None'], dtype='object', name='x')
   >>> psidx.astype(str)
   Index(['10.0', '20.0', '15.0', '30.0', '45.0', 'nan'], dtype='object', name='x')
   ```
   
   I think many people are still using pandas < 1.3, so maybe we'd better to separate the test for old version of pandas for now.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, it's test only
   
   ### How was this patch tested?
   
   Unittest


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #34397: [SPARK-36348][PYTHON][FOLLOWUP] Complete test_astype for index

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34397:
URL: https://github.com/apache/spark/pull/34397#issuecomment-952561659


   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34397: [SPARK-36348][PYTHON][FOLLOWUP] Complete test_astype for index

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34397:
URL: https://github.com/apache/spark/pull/34397#issuecomment-952532797


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49109/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #34397: [SPARK-36348][PYTHON][FOLLOWUP] Complete test_astype for index

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34397:
URL: https://github.com/apache/spark/pull/34397#issuecomment-952542440


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49109/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] itholic commented on pull request #34397: [SPARK-36348][PYTHON][FOLLOWUP] Complete test_astype for index

Posted by GitBox <gi...@apache.org>.
itholic commented on pull request #34397:
URL: https://github.com/apache/spark/pull/34397#issuecomment-952493156


   cc @Yikun @HyukjinKwon @ueshin @xinrong-databricks 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #34397: [SPARK-36348][PYTHON][FOLLOWUP] Complete test_astype for index

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34397:
URL: https://github.com/apache/spark/pull/34397#issuecomment-952497155


   **[Test build #144639 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144639/testReport)** for PR 34397 at commit [`4ab3fee`](https://github.com/apache/spark/commit/4ab3feea32682fa1ed6228a9de0092d5f545e99d).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34397: [SPARK-36348][PYTHON][FOLLOWUP] Complete test_astype for index

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34397:
URL: https://github.com/apache/spark/pull/34397#issuecomment-952561324


   **[Test build #144644 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144644/testReport)** for PR 34397 at commit [`4ab3fee`](https://github.com/apache/spark/commit/4ab3feea32682fa1ed6228a9de0092d5f545e99d).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34397: [SPARK-36348][PYTHON][FOLLOWUP] Complete test_astype for index

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34397:
URL: https://github.com/apache/spark/pull/34397#issuecomment-952542440


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49109/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34397: [SPARK-36348][PYTHON][FOLLOWUP] Complete test_astype for index

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34397:
URL: https://github.com/apache/spark/pull/34397#issuecomment-952497155


   **[Test build #144639 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144639/testReport)** for PR 34397 at commit [`4ab3fee`](https://github.com/apache/spark/commit/4ab3feea32682fa1ed6228a9de0092d5f545e99d).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #34397: [SPARK-36348][PYTHON][FOLLOWUP] Complete test_astype for index

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34397:
URL: https://github.com/apache/spark/pull/34397#issuecomment-952549477


   **[Test build #144644 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144644/testReport)** for PR 34397 at commit [`4ab3fee`](https://github.com/apache/spark/commit/4ab3feea32682fa1ed6228a9de0092d5f545e99d).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #34397: [SPARK-36348][PYTHON][FOLLOWUP] Complete test_astype for index

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34397:
URL: https://github.com/apache/spark/pull/34397#issuecomment-952511779


   retest this pleasse


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #34397: [SPARK-36348][PYTHON][FOLLOWUP] Complete test_astype for index

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34397:
URL: https://github.com/apache/spark/pull/34397#issuecomment-952568688


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144644/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34397: [SPARK-36348][PYTHON][FOLLOWUP] Complete test_astype for index

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34397:
URL: https://github.com/apache/spark/pull/34397#issuecomment-952576721


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49115/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #34397: [SPARK-36348][PYTHON][FOLLOWUP] Complete test_astype for index

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34397:
URL: https://github.com/apache/spark/pull/34397#issuecomment-952548229


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34397: [SPARK-36348][PYTHON][FOLLOWUP] Complete test_astype for index

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34397:
URL: https://github.com/apache/spark/pull/34397#issuecomment-952612387


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49115/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #34397: [SPARK-36348][PYTHON][FOLLOWUP] Complete test_astype for index

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34397:
URL: https://github.com/apache/spark/pull/34397#issuecomment-952612434


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49115/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34397: [SPARK-36348][PYTHON][FOLLOWUP] Complete test_astype for index

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34397:
URL: https://github.com/apache/spark/pull/34397#issuecomment-952612434


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49115/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34397: [SPARK-36348][PYTHON][FOLLOWUP] Complete test_astype for index

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34397:
URL: https://github.com/apache/spark/pull/34397#issuecomment-952519239


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144639/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34397: [SPARK-36348][PYTHON][FOLLOWUP] Complete test_astype for index

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34397:
URL: https://github.com/apache/spark/pull/34397#issuecomment-952549477


   **[Test build #144644 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144644/testReport)** for PR 34397 at commit [`4ab3fee`](https://github.com/apache/spark/commit/4ab3feea32682fa1ed6228a9de0092d5f545e99d).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34397: [SPARK-36348][PYTHON][FOLLOWUP] Complete test_astype for index

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34397:
URL: https://github.com/apache/spark/pull/34397#issuecomment-952568688


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144644/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #34397: [SPARK-36348][PYTHON][FOLLOWUP] Complete test_astype for index

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34397:
URL: https://github.com/apache/spark/pull/34397#issuecomment-952519239


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144639/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34397: [SPARK-36348][PYTHON][FOLLOWUP] Complete test_astype for index

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34397:
URL: https://github.com/apache/spark/pull/34397#issuecomment-952505489


   **[Test build #144639 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144639/testReport)** for PR 34397 at commit [`4ab3fee`](https://github.com/apache/spark/commit/4ab3feea32682fa1ed6228a9de0092d5f545e99d).
    * This patch **fails PySpark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34397: [SPARK-36348][PYTHON][FOLLOWUP] Complete test_astype for index

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34397:
URL: https://github.com/apache/spark/pull/34397#issuecomment-952515095


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49109/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon removed a comment on pull request #34397: [SPARK-36348][PYTHON][FOLLOWUP] Complete test_astype for index

Posted by GitBox <gi...@apache.org>.
HyukjinKwon removed a comment on pull request #34397:
URL: https://github.com/apache/spark/pull/34397#issuecomment-952511779


   retest this pleasse


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #34397: [SPARK-36348][PYTHON][FOLLOWUP] Complete test_astype for index

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34397:
URL: https://github.com/apache/spark/pull/34397


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org