You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/20 10:32:55 UTC
[GitHub] TisonKun commented on a change in pull request #7719: [FLINK-10569]
Remove Instance usage in ExecutionGraphDeploymentTest
TisonKun commented on a change in pull request #7719: [FLINK-10569] Remove Instance usage in ExecutionGraphDeploymentTest
URL: https://github.com/apache/flink/pull/7719#discussion_r258421202
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionVertexDeploymentTest.java
##########
@@ -273,15 +270,7 @@ public void testFailExternallyDuringDeploy() {
}
};
- TestingLogicalSlot testingLogicalSlot =
- new TestingLogicalSlot(
- new LocalTaskManagerLocation(),
- blockSubmitGateway,
- 0,
- new AllocationID(),
- new SlotRequestId(),
- new SlotSharingGroupId(),
- null);
+ TestingLogicalSlot testingLogicalSlot = new TestingLogicalSlot(blockSubmitGateway);
Review comment:
This change belongs to commit `[hotfix] Introduce a convenient constructor of TestingLogicalSlot`. Does it make sense or I should revert it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services