[jira] [Commented] (CASSANDRA-12651) Failure in SecondaryIndexTest.testAllowFilteringOnPartitionKeyWithSecondaryIndex

["Sam Tunnicliffe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-12651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15651477#comment-15651477 ] 

Sam Tunnicliffe commented on CASSANDRA-12651:
---------------------------------------------

I'm not convinced that the issue is a name clash. Where we've previously seen name clashes (CASSANDRA-12834 for instance, which is the same failure as reported in the 2 supplementary CI runs mentioned above), the problem is reuse of an identifier by different tests within a fixture. In that case, the async cleanup in the teardown races with a CREATE statement. Here though, the index name is not reused anywhere and if it were, the CREATE INDEX has no IF NOT EXISTS, so we'd likely see that request rejected rather than spurious query results. 

What seems odd to me is that in all of the SecondaryIndexTest failures above, the invalid results are returned only after flush. That is, the test does: 
{code}
run query X;
flush;
run query X;
{code}
So on each occasion, the exact same query executes and returns the expected results almost immediately prior to failure. I accept that 7 test runs is a small sample, but to me it points towards something flush related. 

I've added some logging to try and pin down the cause a bit better, but as [~ifesdjeen] noted, this is pretty damn hard to repro on demand, so I've been running the test in pretty much a constant loop, but so far had no luck. I'll update if/when I see a failure.

> Failure in SecondaryIndexTest.testAllowFilteringOnPartitionKeyWithSecondaryIndex
> --------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-12651
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12651
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Testing
>            Reporter: Joel Knighton
>            Assignee: Alex Petrov
>              Labels: test-failure
>
> This has failed with/without compression.
> Stacktrace:
> {code}
> junit.framework.AssertionFailedError: Got less rows than expected. Expected 2 but got 0
> 	at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:909)
> 	at org.apache.cassandra.cql3.validation.entities.SecondaryIndexTest.lambda$testAllowFilteringOnPartitionKeyWithSecondaryIndex$78(SecondaryIndexTest.java:1228)
> 	at org.apache.cassandra.cql3.validation.entities.SecondaryIndexTest$$Lambda$293/218688965.apply(Unknown Source)
> 	at org.apache.cassandra.cql3.CQLTester.beforeAndAfterFlush(CQLTester.java:1215)
> 	at org.apache.cassandra.cql3.validation.entities.SecondaryIndexTest.testAllowFilteringOnPartitionKeyWithSecondaryIndex(SecondaryIndexTest.java:1218)
> {code}
> Examples:
> http://cassci.datastax.com/job/trunk_testall/1176/testReport/org.apache.cassandra.cql3.validation.entities/SecondaryIndexTest/testAllowFilteringOnPartitionKeyWithSecondaryIndex/
> http://cassci.datastax.com/job/trunk_testall/1176/testReport/org.apache.cassandra.cql3.validation.entities/SecondaryIndexTest/testAllowFilteringOnPartitionKeyWithSecondaryIndex_compression/
> http://cassci.datastax.com/job/trunk_testall/1219/testReport/org.apache.cassandra.cql3.validation.entities/SecondaryIndexTest/testAllowFilteringOnPartitionKeyWithSecondaryIndex/
> http://cassci.datastax.com/job/trunk_testall/1216/testReport/org.apache.cassandra.cql3.validation.entities/SecondaryIndexTest/testAllowFilteringOnPartitionKeyWithSecondaryIndex/
> http://cassci.datastax.com/job/trunk_testall/1208/testReport/org.apache.cassandra.cql3.validation.entities/SecondaryIndexTest/testAllowFilteringOnPartitionKeyWithSecondaryIndex/
> http://cassci.datastax.com/job/trunk_testall/1176/testReport/org.apache.cassandra.cql3.validation.entities/SecondaryIndexTest/testAllowFilteringOnPartitionKeyWithSecondaryIndex/
> http://cassci.datastax.com/job/trunk_testall/1175/testReport/org.apache.cassandra.cql3.validation.entities/SecondaryIndexTest/testAllowFilteringOnPartitionKeyWithSecondaryIndex/
> May or may not be related, but there's a test failure (index duplicate):
> http://cassci.datastax.com/view/Dev/view/carlyeks/job/carlyeks-ticket-11803-3.X-testall/lastCompletedBuild/testReport/org.apache.cassandra.index.internal/CassandraIndexTest/indexOnFirstClusteringColumn_compression/
> http://cassci.datastax.com/job/ifesdjeen-11803-test-fix-trunk-testall/1/testReport/junit/org.apache.cassandra.index.internal/CassandraIndexTest/indexOnFirstClusteringColumn_compression/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)