You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/26 03:59:33 UTC
[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #4482:
Correct the `DataTypeName` for each DataBase
tristaZero opened a new issue #4482: Correct the `DataTypeName` for each DataBase
URL: https://github.com/apache/incubator-shardingsphere/issues/4482
The definition of `DataTypeName` in `RuleName.g4` of each DataBase is not correct so far, therefore this issue is created to correct them. The sub-task list is below,
- [ ] Correct the `DataTypeName` for `MySQL`.
- [ ] Correct the `DataTypeName` for `PostgreSQL`.
- [ ] Correct the `DataTypeName` for `SQLServer`.
- [ ] Correct the `DataTypeName` for `Oracle`.
- [ ] Correct the `DataTypeName` for `SQL92`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #4482:
Correct the `DataTypeName` for each DataBase
Posted by GitBox <gi...@apache.org>.
tristaZero opened a new issue #4482: Correct the `DataTypeName` for each DataBase
URL: https://github.com/apache/incubator-shardingsphere/issues/4482
The definition of `DataTypeName` in `RuleName.g4`(Antlr grammer file) of each DataBase is not correct so far, therefore this issue is created to correct them. The sub-task list is below,
- [x] Correct the `DataTypeName` for `MySQL`.
- [x] Correct the `DataTypeName` for `PostgreSQL`.
- [ ] Correct the `DataTypeName` for `SQLServer`.
- [ ] Correct the `DataTypeName` for `Oracle`.
- [ ] Correct the `DataTypeName` for `SQL92`.
Q1: How to learn about the definition of `DataTypeName`?
A:
- Official document of each DataBase, i.g [MySQL](https://dev.mysql.com/doc/refman/8.0/en/data-types.html).
- [Antlr SQL grammer](https://github.com/antlr/grammars-v4/tree/master/sql)
- Other related Website. (I am not sure. 😃 )
Q2: Which file of ShardingSphere does `DataTypeName` exist?
A: All files named with `RuleName.g4`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue
#4482: Correct the `DataTypeName` for each DataBase
Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on issue #4482: Correct the `DataTypeName` for each DataBase
URL: https://github.com/apache/incubator-shardingsphere/issues/4482#issuecomment-591776847
Hi @yuzel You made a good start for this issue, good job. 👍
BTW, are you willing to go on with PostgreSQL or other ones?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero closed issue #4482: Correct
the `DataTypeName` for each DataBase
Posted by GitBox <gi...@apache.org>.
tristaZero closed issue #4482: Correct the `DataTypeName` for each DataBase
URL: https://github.com/apache/incubator-shardingsphere/issues/4482
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] yuzel commented on issue #4482: Correct
the `DataTypeName` for each DataBase
Posted by GitBox <gi...@apache.org>.
yuzel commented on issue #4482: Correct the `DataTypeName` for each DataBase
URL: https://github.com/apache/incubator-shardingsphere/issues/4482#issuecomment-591799246
> Hi @yuzel You made a good start for this issue, good job. 👍
> BTW, are you willing to go on with PostgreSQL or other ones?
Yes, I am going to continue to modify PostgreSQL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4482:
Correct the `DataTypeName` for each DataBase
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #4482: Correct the `DataTypeName` for each DataBase
URL: https://github.com/apache/incubator-shardingsphere/issues/4482#issuecomment-591776847
Hi @yuzel You made a good start for this issue, good job. 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] yuzel commented on issue #4482: Correct
the `DataTypeName` for each DataBase
Posted by GitBox <gi...@apache.org>.
yuzel commented on issue #4482: Correct the `DataTypeName` for each DataBase
URL: https://github.com/apache/incubator-shardingsphere/issues/4482#issuecomment-591234894
Ok, i can support mysql and postgresql first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4482:
Correct the `DataTypeName` for each DataBase
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #4482: Correct the `DataTypeName` for each DataBase
URL: https://github.com/apache/incubator-shardingsphere/issues/4482#issuecomment-602147078
@yuzel Your continual contribution helps this ISSUE complete. Very appreciated your effort. Hope see your interaction in community more. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero closed issue #4482: Correct
the `DataTypeName` for each DataBase
Posted by GitBox <gi...@apache.org>.
tristaZero closed issue #4482: Correct the `DataTypeName` for each DataBase
URL: https://github.com/apache/incubator-shardingsphere/issues/4482
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services