You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by kiwinewt <gi...@git.apache.org> on 2014/11/24 02:51:27 UTC
[GitHub] cordova-plugin-camera pull request: Correct image resolution selec...
GitHub user kiwinewt opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/56
Correct image resolution selection
Update the code to correctly select the CameraCaptureUIMaxPhotoResolution based on the Windows guidelines.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kiwinewt/cordova-plugin-camera patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/56.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #56
----
commit c0e2d1f3433ea12f9ffc1550aec275873ba76052
Author: Nate Walker <ki...@gmail.com>
Date: 2014-11-24T01:49:26Z
Correct image resolution selection
Update the code to correctly select the CameraCaptureUIMaxPhotoResolution based on the Windows guidelines.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Correct image resolution selec...
Posted by muratsu <gi...@git.apache.org>.
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/56#issuecomment-121375282
@kiwinewt thanks for the contribution. The right approach here is to take into account the max num of pixels instead of a certain height or width limit.
VeryLarge5M = 5 * 1000 * 1000;
Large3M = 3 * 1000 * 1000;
MediumXga = 1024 * 768;
SmallVga = 640 * 480;
VerySmallQvga = 320 * 240;
If you can modify the code as such, I'll be glad to accept your PR - thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Correct image resolution selec...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/56
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org