You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/19 04:01:55 UTC

[GitHub] [spark] AngersZhuuuu opened a new pull request #33409: [SPARK-36021][SQL] Schema check should check inner field too

AngersZhuuuu opened a new pull request #33409:
URL: https://github.com/apache/spark/pull/33409


   ### What changes were proposed in this pull request?
   When inner field have wrong schema filed name should check field name too.
   ![image](https://user-images.githubusercontent.com/46485123/126101009-c192d87f-1e18-4355-ad53-1419dacdeb76.png)
   
   
   ### Why are the changes needed?
   Early check early faield
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   Added UT
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882410053


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141220/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33409: [SPARK-36021][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #33409:
URL: https://github.com/apache/spark/pull/33409#discussion_r672027337



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala
##########
@@ -593,8 +593,14 @@ private[sql] object ParquetSchemaConverter {
        """.stripMargin.split("\n").mkString(" ").trim)
   }
 
-  def checkFieldNames(names: Seq[String]): Unit = {
-    names.foreach(checkFieldName)
+  def checkFieldNames(schema: StructType): Unit = {
+    schema.map(field => field.name -> field.dataType)
+      .foreach {
+        case (name, struct: StructType) =>

Review comment:
       Nice suggestion, done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882371460


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45743/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33409: [SPARK-36021][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882256940






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33409: [SPARK-36021][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882216558


   **[Test build #141218 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141218/testReport)** for PR 33409 at commit [`cda8c31`](https://github.com/apache/spark/commit/cda8c31ccd29940683c4dbf7279827d1e3db7053).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #33409:
URL: https://github.com/apache/spark/pull/33409#discussion_r672896677



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
##########
@@ -52,8 +52,13 @@ private[sql] object OrcFileFormat {
     }
   }
 
-  def checkFieldNames(names: Seq[String]): Unit = {
-    names.foreach(checkFieldName)
+  def checkFieldNames(schema: StructType): Unit = {
+    schema.foreach {

Review comment:
       Done

##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala
##########
@@ -593,8 +593,13 @@ private[sql] object ParquetSchemaConverter {
        """.stripMargin.split("\n").mkString(" ").trim)
   }
 
-  def checkFieldNames(names: Seq[String]): Unit = {
-    names.foreach(checkFieldName)
+  def checkFieldNames(schema: StructType): Unit = {
+    schema.foreach {
+      case field if field.dataType.isInstanceOf[StructType] =>
+        checkFieldName(field.name)
+        checkFieldNames(field.dataType.asInstanceOf[StructType])

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882235105


   **[Test build #141220 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141220/testReport)** for PR 33409 at commit [`471d1b8`](https://github.com/apache/spark/commit/471d1b841375d66215ebe5b4f63a4d54b5d3c4d9).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882476964






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882449608


   **[Test build #141245 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141245/testReport)** for PR 33409 at commit [`3303ccb`](https://github.com/apache/spark/commit/3303ccb309ea06e53052934a8b457c4b58d8ed22).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33409: [SPARK-36021][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882256941






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun edited a comment on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883069206


   The error code is the following. It looks like OOM happening again.
   - https://github.com/AngersZhuuuu/spark/runs/3110053861?check_suite_focus=true
   ```
    ./build/mvn: line 178:  1699 Killed                  "${MVN_BIN}" "$@"
   2021-07-20T04:37:47.6486105Z ##[error]Process completed with exit code 137.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882660794


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141245/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882287866


   **[Test build #141229 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141229/testReport)** for PR 33409 at commit [`8285ef0`](https://github.com/apache/spark/commit/8285ef0b7e55b53d902ab77ada8636815fb16f19).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33409: [SPARK-36021][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882216558


   **[Test build #141218 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141218/testReport)** for PR 33409 at commit [`cda8c31`](https://github.com/apache/spark/commit/cda8c31ccd29940683c4dbf7279827d1e3db7053).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882406477


   **[Test build #141220 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141220/testReport)** for PR 33409 at commit [`471d1b8`](https://github.com/apache/spark/commit/471d1b841375d66215ebe5b4f63a4d54b5d3c4d9).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882659210


   **[Test build #141245 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141245/testReport)** for PR 33409 at commit [`3303ccb`](https://github.com/apache/spark/commit/3303ccb309ea06e53052934a8b457c4b58d8ed22).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan closed pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #33409:
URL: https://github.com/apache/spark/pull/33409


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882476964


   Kubernetes integration test unable to build dist.
   
   exiting with code: 1
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45759/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883051150


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45805/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on pull request #33409: [SPARK-36021][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882216303


   ping @dongjoon-hyun @HyukjinKwon @cloud-fan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu edited a comment on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu edited a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883104093


   > Thank you for pinging me, @AngersZhuuuu . BTW, you should use `[FOLLOWUP]` when you reuse the JIRA id.
   
   Hmmmm, it's not a reuse jira. I write wrong jira id  `SPARK-36021` first  and change to correct `SPARK-36201`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu edited a comment on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu edited a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883104093


   > Thank you for pinging me, @AngersZhuuuu . BTW, you should use `[FOLLOWUP]` when you reuse the JIRA id.
   
   Hmmmm, it's not a reuse jira. I write wrong jira id  `SPARK-36021` first  and change to correct `SPARK-36201`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883011287


   **[Test build #141291 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141291/testReport)** for PR 33409 at commit [`c43d1b4`](https://github.com/apache/spark/commit/c43d1b43cf3588026633c87481b7f7b499b0a7d8).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882955387


   hm, GA test seems failing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882235105






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33409:
URL: https://github.com/apache/spark/pull/33409#discussion_r672894317



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
##########
@@ -52,8 +52,13 @@ private[sql] object OrcFileFormat {
     }
   }
 
-  def checkFieldNames(names: Seq[String]): Unit = {
-    names.foreach(checkFieldName)
+  def checkFieldNames(schema: StructType): Unit = {
+    schema.foreach {

Review comment:
       nit:
   ```
   schema.foreach { field =>
     checkFieldName(field.name)
     field.dataType match {
       case s: StructType => checkFieldNames(s)
       case _ =>
     }
   }
   ```

##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala
##########
@@ -593,8 +593,13 @@ private[sql] object ParquetSchemaConverter {
        """.stripMargin.split("\n").mkString(" ").trim)
   }
 
-  def checkFieldNames(names: Seq[String]): Unit = {
-    names.foreach(checkFieldName)
+  def checkFieldNames(schema: StructType): Unit = {
+    schema.foreach {
+      case field if field.dataType.isInstanceOf[StructType] =>
+        checkFieldName(field.name)
+        checkFieldNames(field.dataType.asInstanceOf[StructType])

Review comment:
       ditto




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883378935


   GA is quite unstable now. I'm merging it to master/3.2 since jenkins has passed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883220802


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141291/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883069206


   The error code is the following. It looks like OOM happening again.
   ```
    ./build/mvn: line 178:  1699 Killed                  "${MVN_BIN}" "$@"
   2021-07-20T04:37:47.6486105Z ##[error]Process completed with exit code 137.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883067722






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882371460






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882371460






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882410053


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141220/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882445681


   @AngersZhuuuu would you mind retriggering the test (https://github.com/AngersZhuuuu/spark/actions/runs/1044234803)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #33409:
URL: https://github.com/apache/spark/pull/33409#discussion_r672896677



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
##########
@@ -52,8 +52,13 @@ private[sql] object OrcFileFormat {
     }
   }
 
-  def checkFieldNames(names: Seq[String]): Unit = {
-    names.foreach(checkFieldName)
+  def checkFieldNames(schema: StructType): Unit = {
+    schema.foreach {

Review comment:
       Done

##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala
##########
@@ -593,8 +593,13 @@ private[sql] object ParquetSchemaConverter {
        """.stripMargin.split("\n").mkString(" ").trim)
   }
 
-  def checkFieldNames(names: Seq[String]): Unit = {
-    names.foreach(checkFieldName)
+  def checkFieldNames(schema: StructType): Unit = {
+    schema.foreach {
+      case field if field.dataType.isInstanceOf[StructType] =>
+        checkFieldName(field.name)
+        checkFieldNames(field.dataType.asInstanceOf[StructType])

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882485658


   **[Test build #141229 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141229/testReport)** for PR 33409 at commit [`8285ef0`](https://github.com/apache/spark/commit/8285ef0b7e55b53d902ab77ada8636815fb16f19).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883301554


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45830/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882484111


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45759/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882371431






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882371431


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45743/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33409: [SPARK-36021][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882235105


   **[Test build #141220 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141220/testReport)** for PR 33409 at commit [`471d1b8`](https://github.com/apache/spark/commit/471d1b841375d66215ebe5b4f63a4d54b5d3c4d9).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883051150


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45805/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882484111






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33409: [SPARK-36021][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882217416


   **[Test build #141218 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141218/testReport)** for PR 33409 at commit [`cda8c31`](https://github.com/apache/spark/commit/cda8c31ccd29940683c4dbf7279827d1e3db7053).
    * This patch **fails Scala style tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun edited a comment on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883069206


   The error code is the following. It looks like OOM happening again.
   - https://github.com/AngersZhuuuu/spark/runs/3110053861?check_suite_focus=true
   ```
    ./build/mvn: line 178:  1699 Killed                  "${MVN_BIN}" "$@"
   2021-07-20T04:37:47.6486105Z ##[error]Process completed with exit code 137.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33409:
URL: https://github.com/apache/spark/pull/33409#discussion_r672894317



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
##########
@@ -52,8 +52,13 @@ private[sql] object OrcFileFormat {
     }
   }
 
-  def checkFieldNames(names: Seq[String]): Unit = {
-    names.foreach(checkFieldName)
+  def checkFieldNames(schema: StructType): Unit = {
+    schema.foreach {

Review comment:
       nit:
   ```
   schema.foreach { field =>
     checkFieldName(field.name)
     field.dataType match {
       case s: StructType => checkFieldNames(s)
       case _ =>
     }
   }
   ```

##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala
##########
@@ -593,8 +593,13 @@ private[sql] object ParquetSchemaConverter {
        """.stripMargin.split("\n").mkString(" ").trim)
   }
 
-  def checkFieldNames(names: Seq[String]): Unit = {
-    names.foreach(checkFieldName)
+  def checkFieldNames(schema: StructType): Unit = {
+    schema.foreach {
+      case field if field.dataType.isInstanceOf[StructType] =>
+        checkFieldName(field.name)
+        checkFieldNames(field.dataType.asInstanceOf[StructType])

Review comment:
       ditto




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882344636


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45743/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883104576


   > The error code is the following. It looks like OOM happening again.
   > 
   > * https://github.com/AngersZhuuuu/spark/runs/3110053861?check_suite_focus=true
   > 
   > ```
   >  ./build/mvn: line 178:  1699 Killed                  "${MVN_BIN}" "$@"
   > 2021-07-20T04:37:47.6486105Z ##[error]Process completed with exit code 137.
   > ```
   
   Yea, should not be related to my pr


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883374231


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141315/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882484111


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45759/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882955387


   hm, GA test seems failing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883321320


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45830/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883372473


   **[Test build #141315 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141315/testReport)** for PR 33409 at commit [`6250d3d`](https://github.com/apache/spark/commit/6250d3df2419ecda12686266428d94cb1b2a7254).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882660794


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141245/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883037465


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45805/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33409: [SPARK-36021][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882217431


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141218/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882371460


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45743/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33409:
URL: https://github.com/apache/spark/pull/33409#discussion_r672894317



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
##########
@@ -52,8 +52,13 @@ private[sql] object OrcFileFormat {
     }
   }
 
-  def checkFieldNames(names: Seq[String]): Unit = {
-    names.foreach(checkFieldName)
+  def checkFieldNames(schema: StructType): Unit = {
+    schema.foreach {

Review comment:
       nit:
   ```
   schema.foreach { field =>
     checkFieldName(field.name)
     field.dataType match {
       case s: StructType => checkFieldNames(s)
       case _ =>
     }
   }
   ```

##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala
##########
@@ -593,8 +593,13 @@ private[sql] object ParquetSchemaConverter {
        """.stripMargin.split("\n").mkString(" ").trim)
   }
 
-  def checkFieldNames(names: Seq[String]): Unit = {
-    names.foreach(checkFieldName)
+  def checkFieldNames(schema: StructType): Unit = {
+    schema.foreach {
+      case field if field.dataType.isInstanceOf[StructType] =>
+        checkFieldName(field.name)
+        checkFieldNames(field.dataType.asInstanceOf[StructType])

Review comment:
       ditto




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883150916


   By the way, when this can be fixed and merge this then I can start the follow up work?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33409: [SPARK-36021][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882252237


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45731/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883011287


   **[Test build #141291 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141291/testReport)** for PR 33409 at commit [`c43d1b4`](https://github.com/apache/spark/commit/c43d1b43cf3588026633c87481b7f7b499b0a7d8).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883027098


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45805/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #33409:
URL: https://github.com/apache/spark/pull/33409#discussion_r672896677



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
##########
@@ -52,8 +52,13 @@ private[sql] object OrcFileFormat {
     }
   }
 
-  def checkFieldNames(names: Seq[String]): Unit = {
-    names.foreach(checkFieldName)
+  def checkFieldNames(schema: StructType): Unit = {
+    schema.foreach {

Review comment:
       Done

##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala
##########
@@ -593,8 +593,13 @@ private[sql] object ParquetSchemaConverter {
        """.stripMargin.split("\n").mkString(" ").trim)
   }
 
-  def checkFieldNames(names: Seq[String]): Unit = {
-    names.foreach(checkFieldName)
+  def checkFieldNames(schema: StructType): Unit = {
+    schema.foreach {
+      case field if field.dataType.isInstanceOf[StructType] =>
+        checkFieldName(field.name)
+        checkFieldNames(field.dataType.asInstanceOf[StructType])

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a change in pull request #33409: [SPARK-36021][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #33409:
URL: https://github.com/apache/spark/pull/33409#discussion_r672018403



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala
##########
@@ -593,8 +593,14 @@ private[sql] object ParquetSchemaConverter {
        """.stripMargin.split("\n").mkString(" ").trim)
   }
 
-  def checkFieldNames(names: Seq[String]): Unit = {
-    names.foreach(checkFieldName)
+  def checkFieldNames(schema: StructType): Unit = {
+    schema.map(field => field.name -> field.dataType)
+      .foreach {
+        case (name, struct: StructType) =>

Review comment:
       I think you can traverse with `StructField`? e.g.)
   
   ```scala
     case field if field.dataType.isInstanceOf[StructType]  =>
       checkFieldName(name)
       checkFieldNames(struct)
     case field => checkFieldName(field.name)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883104093


   > Thank you for pinging me, @AngersZhuuuu . BTW, you should use `[FOLLOWUP]` when you reuse the JIRA id.
   
   Hmmmm, it's not a reuse jira. I write wrong jira id to `SPARK-36021` and change to correct `SPARK-36201`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33409: [SPARK-36021][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882252144


   Kubernetes integration test unable to build dist.
   
   exiting with code: 1
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45733/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a change in pull request #33409: [SPARK-36021][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #33409:
URL: https://github.com/apache/spark/pull/33409#discussion_r672018403



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala
##########
@@ -593,8 +593,14 @@ private[sql] object ParquetSchemaConverter {
        """.stripMargin.split("\n").mkString(" ").trim)
   }
 
-  def checkFieldNames(names: Seq[String]): Unit = {
-    names.foreach(checkFieldName)
+  def checkFieldNames(schema: StructType): Unit = {
+    schema.map(field => field.name -> field.dataType)
+      .foreach {
+        case (name, struct: StructType) =>

Review comment:
       I think you can traverse with `StructField`? e.g.)
   
   ```scala
   schema.foreach {
     case field if field.dataType.isInstanceOf[StructType]  =>
       checkFieldName(field.name)
       checkFieldNames(field.dataType.asInstanceOf[StructType])
     case field => checkFieldName(field.name)
   }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883067722


   Wow, the GitHub Action failures look really weird.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883331086


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45830/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882484111






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883374231


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141315/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882445681






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33409: [SPARK-36021][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882287866


   **[Test build #141229 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141229/testReport)** for PR 33409 at commit [`8285ef0`](https://github.com/apache/spark/commit/8285ef0b7e55b53d902ab77ada8636815fb16f19).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883198462


   **[Test build #141291 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141291/testReport)** for PR 33409 at commit [`c43d1b4`](https://github.com/apache/spark/commit/c43d1b43cf3588026633c87481b7f7b499b0a7d8).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `protected abstract class ConnectionProviderBase extends Logging `


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu edited a comment on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu edited a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883104093


   > Thank you for pinging me, @AngersZhuuuu . BTW, you should use `[FOLLOWUP]` when you reuse the JIRA id.
   
   Hmmmm, it's not a reuse jira. I write wrong jira id  `SPARK-36021` first  and change to correct `SPARK-36201`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883331086


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45830/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882447132


   > @AngersZhuuuu would you mind retriggering the test (https://github.com/AngersZhuuuu/spark/actions/runs/1044234803)?
   
   Done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a change in pull request #33409: [SPARK-36021][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #33409:
URL: https://github.com/apache/spark/pull/33409#discussion_r672018403



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala
##########
@@ -593,8 +593,14 @@ private[sql] object ParquetSchemaConverter {
        """.stripMargin.split("\n").mkString(" ").trim)
   }
 
-  def checkFieldNames(names: Seq[String]): Unit = {
-    names.foreach(checkFieldName)
+  def checkFieldNames(schema: StructType): Unit = {
+    schema.map(field => field.name -> field.dataType)
+      .foreach {
+        case (name, struct: StructType) =>

Review comment:
       I think you can traverse with `StructField`? e.g.)
   
   ```scala
     case field if field.dataType.isInstanceOf[StructType]  =>
       checkFieldName(field.name)
       checkFieldNames(field.dataType.asInstanceOf[StructType])
     case field => checkFieldName(field.name)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883069750


   It seems that the master branch's Java 17 job is suffering with the same reason.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883220802


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141291/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882449608


   **[Test build #141245 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141245/testReport)** for PR 33409 at commit [`3303ccb`](https://github.com/apache/spark/commit/3303ccb309ea06e53052934a8b457c4b58d8ed22).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883001709


   > hm, GA test seems failing.
   
   Seems all my UT failed like this, can't find why..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882487024


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141229/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883188093


   **[Test build #141315 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141315/testReport)** for PR 33409 at commit [`6250d3d`](https://github.com/apache/spark/commit/6250d3df2419ecda12686266428d94cb1b2a7254).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33409: [SPARK-36021][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882237421


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45731/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882487024


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141229/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882447132






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883067722






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883188093


   **[Test build #141315 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141315/testReport)** for PR 33409 at commit [`6250d3d`](https://github.com/apache/spark/commit/6250d3df2419ecda12686266428d94cb1b2a7254).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882287866






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun edited a comment on pull request #33409: [SPARK-36201][SQL][FOLLOWUP] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883069206


   The error code is the following. It looks like OOM happening again.
   - https://github.com/AngersZhuuuu/spark/runs/3110053861?check_suite_focus=true
   ```
    ./build/mvn: line 178:  1699 Killed                  "${MVN_BIN}" "$@"
   2021-07-20T04:37:47.6486105Z ##[error]Process completed with exit code 137.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on pull request #33409: [SPARK-36201][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-883001709






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33409: [SPARK-36021][SQL] Schema check should check inner field too

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33409:
URL: https://github.com/apache/spark/pull/33409#issuecomment-882217431


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141218/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org