[GitHub] [incubator-pinot] mcvsubbu commented on issue #4392: Allow customized metrics prefix in pinot controller/broker/server

[GitBox <gi...@apache.org>]

mcvsubbu commented on issue #4392: Allow customized metrics prefix in pinot controller/broker/server
URL: https://github.com/apache/incubator-pinot/pull/4392#issuecomment-511070414
 
 
   > > What is the motivation behind this change?
   > > Also, what about minion?
   > 
   > There are two reasons we are planning this change:
   > 
   > 1. we used to rely on JMX trans for sending metrics from jmx interface to our internal metrics system, however this has been a very annoying thing to maintenance and make it very hard for us to catch up to the latest metrics added to pinot system. So we are migrating to direct metrics reporter that allow us to grab metrics from registry and send to our internal metrics report system. However, our internal metrics system expect a different prefix compared to the one we defined here and it will be great if we can customize the prefix with config
   > 2. well, anything configurable is better than hard-coded values for flexibility :)
   
   Not all the time. It is good to have a product with fewer knobs so a rollout can be faster, and adoption better.
   
   > 
   > for minion we are not really using it, so we are not sure if our change would be correct or not. we could make similar change to minion if you think it is necessary, but it would be a bit hard for us to test it
   
   If we are supporting configurable prexies, might as well support it for all. Yes, please make change to minion as well
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org