[GitHub] piyushghai commented on a change in pull request #13330: [MXNET-1222] Scala Inference "Pandora Box"

[GitBox <gi...@apache.org>]

piyushghai commented on a change in pull request #13330: [MXNET-1222] Scala Inference "Pandora Box"
URL: https://github.com/apache/incubator-mxnet/pull/13330#discussion_r235126944
 
 

 ##########
 File path: scala-package/core/src/main/scala/org/apache/mxnet/Executor.scala
 ##########
 @@ -106,9 +106,9 @@ class Executor private[mxnet](private[mxnet] val handle: ExecutorHandle,
                         "is more efficient than the reverse." +
                         "If you really want to up size, set allowUpSizing = true " +
                         "to enable allocation of new arrays.")
-          newArgDict = newArgDict + (name -> NDArray.empty(newShape, arr.context))
+          newArgDict = newArgDict + (name -> NDArray.empty(newShape, arr.context, arr.dtype))
           if (dArr != null) {
-            newGradDict = newGradDict + (name -> NDArray.empty(newShape, dArr.context))
+            newGradDict = newGradDict + (name -> NDArray.empty(newShape, dArr.context, arr.dtype))
 
 Review comment:
   Should this be dArr.dtype ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services