You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zuston (via GitHub)" <gi...@apache.org> on 2026/02/09 11:03:27 UTC

[PR] [#2724] refactor(spark): Introduce `ReassignExecutor` to clarify shuffle writer logic [uniffle]

zuston opened a new pull request, #2727:
URL: https://github.com/apache/uniffle/pull/2727

   ### What changes were proposed in this pull request?
   
   Introduce `ReassignExecutor` to clarify shuffle writer logic
   
   ### Why are the changes needed?
   
   for #2724
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Existing tests
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#2724] refactor(spark): Introduce `ReassignExecutor` to clarify shuffle writer logic [uniffle]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2727:
URL: https://github.com/apache/uniffle/pull/2727#issuecomment-3871288334

   ## Test Results
    3 175 files  ±0   3 175 suites  ±0   7h 3m 3s ⏱️ + 11m 23s
    1 241 tests ±0   1 232 ✅  -  8   1 💤 ±0  0 ❌ ±0   8 🔥 + 8 
   15 734 runs  ±0  15 655 ✅  - 64  15 💤 ±0  0 ❌ ±0  64 🔥 +64 
   
   For more details on these errors, see [this check](https://github.com/apache/uniffle/runs/62964519002).
   
   Results for commit 05b88b4d. ± Comparison against base commit 1f809ed2.
   
   [test-results]:data:application/gzip;base64,H4sIAIfLiWkC/03MTQ6DIBCG4asY1l3oDAPYyzQKkpD60yCsTO/e0Sh1+T0zeTfhwzis4llho+lRiTWHdN8uxy6FZWYBQoNMfE/7RwOyueZrzdYehvC3d/jsVsB3YWSoCwwxLpHFsMQ8H1XSKM9ZqqSIip3VArfqsa+o2jN2maaQeImaemN66VpQILUZfF/r1isApZ3TGpAsT4/i+wPj1VCBFQEAAA==
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#2724] refactor(spark): Introduce `ReassignExecutor` to simplify shuffle writer logic [uniffle]

Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #2727:
URL: https://github.com/apache/uniffle/pull/2727


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#2724] refactor(spark): Introduce `ReassignExecutor` to simplify shuffle writer logic [uniffle]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2727:
URL: https://github.com/apache/uniffle/pull/2727#issuecomment-3875083029

   ## [Codecov](https://app.codecov.io/gh/apache/uniffle/pull/2727?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `194 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 50.40%. Comparing base ([`69b1b45`](https://app.codecov.io/gh/apache/uniffle/commit/69b1b45bf4e6e03f4cfe3117416a80460f50537c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`96868e3`](https://app.codecov.io/gh/apache/uniffle/commit/96868e3891ed6a6ae1c663d6e0a40edb18cce4d6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/uniffle/pull/2727?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...a/org/apache/uniffle/shuffle/ReassignExecutor.java](https://app.codecov.io/gh/apache/uniffle/pull/2727?src=pr&el=tree&filepath=client-spark%2Fcommon%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Funiffle%2Fshuffle%2FReassignExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zaHVmZmxlL1JlYXNzaWduRXhlY3V0b3IuamF2YQ==) | 0.00% | [194 Missing :warning: ](https://app.codecov.io/gh/apache/uniffle/pull/2727?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2727      +/-   ##
   ============================================
   - Coverage     52.00%   50.40%   -1.60%     
   + Complexity     3566     3267     -299     
   ============================================
     Files           554      533      -21     
     Lines         29448    25733    -3715     
     Branches       2739     2344     -395     
   ============================================
   - Hits          15315    12972    -2343     
   + Misses        13133    11925    -1208     
   + Partials       1000      836     -164     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/uniffle/pull/2727?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org