[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1154: [HUDI-406]: added default partition path in TimestampBasedKeyGenerator

[GitBox <gi...@apache.org>]

bvaradar commented on a change in pull request #1154: [HUDI-406]: added default partition path in TimestampBasedKeyGenerator
URL: https://github.com/apache/incubator-hudi/pull/1154#discussion_r362132256
 
 

 ##########
 File path: hudi-spark/src/main/java/org/apache/hudi/DataSourceUtils.java
 ##########
 @@ -64,6 +64,14 @@ public static String getNullableNestedFieldValAsString(GenericRecord record, Str
     }
   }
 
+  public static Object getNullableNestedFieldVal(GenericRecord record, String fieldName) {
+    try {
+      return getNestedFieldVal(record, fieldName);
 
 Review comment:
   Instead of letting getNestedFieldVal throw an exception and then handling it (more compute intensive), can you add pass additional flag to getNestedFieldVal to return null instead of throwing the exception ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services