You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2019/11/04 20:59:33 UTC

[Impala-ASF-CR] IMPALA-9085: [DOCS] Refactored impala s3.xml

Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14627


Change subject: IMPALA-9085: [DOCS] Refactored impala_s3.xml
......................................................................

IMPALA-9085: [DOCS] Refactored impala_s3.xml

Change-Id: Ib274968a0412b4b8757f31ab674d4b82311de70a
---
M docs/shared/impala_common.xml
M docs/topics/impala_s3.xml
2 files changed, 286 insertions(+), 442 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/14627/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib274968a0412b4b8757f31ab674d4b82311de70a
Gerrit-Change-Number: 14627
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>

[Impala-ASF-CR] IMPALA-9085: [DOCS] Refactored impala s3.xml

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14627 )

Change subject: IMPALA-9085: [DOCS] Refactored impala_s3.xml
......................................................................


Patch Set 3:

Sahil and Joe,
I addressed all the comments, and have one remaining question in
the google doc. Please take a look and let me know if I can move
this along.
Thanks!


-- 
To view, visit http://gerrit.cloudera.org:8080/14627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib274968a0412b4b8757f31ab674d4b82311de70a
Gerrit-Change-Number: 14627
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Nov 2019 22:54:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9085: [DOCS] Refactored impala s3.xml

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14627 )

Change subject: IMPALA-9085: [DOCS] Refactored impala_s3.xml
......................................................................


Patch Set 3:

Joe and Sahil,
Could you check if this can be approved?


-- 
To view, visit http://gerrit.cloudera.org:8080/14627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib274968a0412b4b8757f31ab674d4b82311de70a
Gerrit-Change-Number: 14627
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Nov 2019 18:48:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9085: [DOCS] Refactored impala s3.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14627 )

Change subject: IMPALA-9085: [DOCS] Refactored impala_s3.xml
......................................................................


Patch Set 4: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/535/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/14627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib274968a0412b4b8757f31ab674d4b82311de70a
Gerrit-Change-Number: 14627
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2019 20:56:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9085: [DOCS] Refactored impala s3.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14627 )

Change subject: IMPALA-9085: [DOCS] Refactored impala_s3.xml
......................................................................


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/526/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/14627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib274968a0412b4b8757f31ab674d4b82311de70a
Gerrit-Change-Number: 14627
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Nov 2019 21:22:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9085: [DOCS] Refactored impala s3.xml

Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14627 )

Change subject: IMPALA-9085: [DOCS] Refactored impala_s3.xml
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib274968a0412b4b8757f31ab674d4b82311de70a
Gerrit-Change-Number: 14627
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Nov 2019 23:56:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9085: [DOCS] Refactored impala s3.xml

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14627 )

Change subject: IMPALA-9085: [DOCS] Refactored impala_s3.xml
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14627/3/docs/topics/impala_s3.xml
File docs/topics/impala_s3.xml:

http://gerrit.cloudera.org:8080/#/c/14627/3/docs/topics/impala_s3.xml@a406
PS3, Line 406: 
> why delete this example?
I don't see the example adding values. It is repeating what's already said or describing things very straightforard.
Let me know if you feel this whole section should be added back in.



-- 
To view, visit http://gerrit.cloudera.org:8080/14627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib274968a0412b4b8757f31ab674d4b82311de70a
Gerrit-Change-Number: 14627
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Nov 2019 19:31:40 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9085: [DOCS] Refactored impala s3.xml

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14627 )

Change subject: IMPALA-9085: [DOCS] Refactored impala_s3.xml
......................................................................

IMPALA-9085: [DOCS] Refactored impala_s3.xml

Change-Id: Ib274968a0412b4b8757f31ab674d4b82311de70a
Reviewed-on: http://gerrit.cloudera.org:8080/14627
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Sahil Takiar <st...@cloudera.com>
---
M docs/shared/impala_common.xml
M docs/topics/impala_s3.xml
2 files changed, 352 insertions(+), 542 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Sahil Takiar: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/14627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib274968a0412b4b8757f31ab674d4b82311de70a
Gerrit-Change-Number: 14627
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>

[Impala-ASF-CR] IMPALA-9085: [DOCS] Refactored impala s3.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14627 )

Change subject: IMPALA-9085: [DOCS] Refactored impala_s3.xml
......................................................................


Patch Set 3: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/528/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/14627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib274968a0412b4b8757f31ab674d4b82311de70a
Gerrit-Change-Number: 14627
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Nov 2019 19:13:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9085: [DOCS] Refactored impala s3.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14627 )

Change subject: IMPALA-9085: [DOCS] Refactored impala_s3.xml
......................................................................


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/526/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/14627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib274968a0412b4b8757f31ab674d4b82311de70a
Gerrit-Change-Number: 14627
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Nov 2019 20:59:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9085: [DOCS] Refactored impala s3.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14627 )

Change subject: IMPALA-9085: [DOCS] Refactored impala_s3.xml
......................................................................


Patch Set 2: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/527/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/14627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib274968a0412b4b8757f31ab674d4b82311de70a
Gerrit-Change-Number: 14627
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Nov 2019 00:48:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9085: [DOCS] Refactored impala s3.xml

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Sahil Takiar, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14627

to look at the new patch set (#3).

Change subject: IMPALA-9085: [DOCS] Refactored impala_s3.xml
......................................................................

IMPALA-9085: [DOCS] Refactored impala_s3.xml

Change-Id: Ib274968a0412b4b8757f31ab674d4b82311de70a
---
M docs/shared/impala_common.xml
M docs/topics/impala_s3.xml
2 files changed, 303 insertions(+), 471 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/14627/3
-- 
To view, visit http://gerrit.cloudera.org:8080/14627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib274968a0412b4b8757f31ab674d4b82311de70a
Gerrit-Change-Number: 14627
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>

[Impala-ASF-CR] IMPALA-9085: [DOCS] Refactored impala s3.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14627 )

Change subject: IMPALA-9085: [DOCS] Refactored impala_s3.xml
......................................................................


Patch Set 3:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/528/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/14627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib274968a0412b4b8757f31ab674d4b82311de70a
Gerrit-Change-Number: 14627
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Nov 2019 19:07:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9085: [DOCS] Refactored impala s3.xml

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Sahil Takiar, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14627

to look at the new patch set (#4).

Change subject: IMPALA-9085: [DOCS] Refactored impala_s3.xml
......................................................................

IMPALA-9085: [DOCS] Refactored impala_s3.xml

Change-Id: Ib274968a0412b4b8757f31ab674d4b82311de70a
---
M docs/shared/impala_common.xml
M docs/topics/impala_s3.xml
2 files changed, 352 insertions(+), 542 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/14627/4
-- 
To view, visit http://gerrit.cloudera.org:8080/14627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib274968a0412b4b8757f31ab674d4b82311de70a
Gerrit-Change-Number: 14627
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>

[Impala-ASF-CR] IMPALA-9085: [DOCS] Refactored impala s3.xml

Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14627 )

Change subject: IMPALA-9085: [DOCS] Refactored impala_s3.xml
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14627/3/docs/topics/impala_s3.xml
File docs/topics/impala_s3.xml:

http://gerrit.cloudera.org:8080/#/c/14627/3/docs/topics/impala_s3.xml@a406
PS3, Line 406: 
why delete this example?



-- 
To view, visit http://gerrit.cloudera.org:8080/14627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib274968a0412b4b8757f31ab674d4b82311de70a
Gerrit-Change-Number: 14627
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Nov 2019 01:37:46 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9085: [DOCS] Refactored impala s3.xml

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Sahil Takiar, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14627

to look at the new patch set (#2).

Change subject: IMPALA-9085: [DOCS] Refactored impala_s3.xml
......................................................................

IMPALA-9085: [DOCS] Refactored impala_s3.xml

Change-Id: Ib274968a0412b4b8757f31ab674d4b82311de70a
---
M docs/shared/impala_common.xml
M docs/topics/impala_s3.xml
2 files changed, 296 insertions(+), 471 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/14627/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib274968a0412b4b8757f31ab674d4b82311de70a
Gerrit-Change-Number: 14627
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>

[Impala-ASF-CR] IMPALA-9085: [DOCS] Refactored impala s3.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14627 )

Change subject: IMPALA-9085: [DOCS] Refactored impala_s3.xml
......................................................................


Patch Set 4:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/535/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/14627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib274968a0412b4b8757f31ab674d4b82311de70a
Gerrit-Change-Number: 14627
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2019 20:29:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9085: [DOCS] Refactored impala s3.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14627 )

Change subject: IMPALA-9085: [DOCS] Refactored impala_s3.xml
......................................................................


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/527/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/14627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib274968a0412b4b8757f31ab674d4b82311de70a
Gerrit-Change-Number: 14627
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Nov 2019 00:25:29 +0000
Gerrit-HasComments: No