You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Silas Sewell (JIRA)" <ji...@apache.org> on 2009/05/17 03:35:45 UTC
[jira] Created: (THRIFT-509) C# Library Does Not Provide Strong
Name
C# Library Does Not Provide Strong Name
---------------------------------------
Key: THRIFT-509
URL: https://issues.apache.org/jira/browse/THRIFT-509
Project: Thrift
Issue Type: Bug
Components: Library (C#)
Environment: Fedora 10 i386 - Mono version 2.0.1 - Thrift r770888
Reporter: Silas Sewell
Priority: Minor
I'm in the process of having a Thrift package reviewed for Fedora. Unfortunately the C# library is failing to register because it thinks Thrift.dll doesn't provide a "strong name".
If this is something that could be added to the library it would be very much appreciated.
Error:
DEBUG: + gacutil -i lib/csharp/Thrift.dll -f -package Thrift -root /builddir/build/BUILDROOT/thrift-0.0-0.fc10.20090501svn770888.i386/usr/lib
DEBUG: Failure adding assembly lib/csharp/Thrift.dll to the cache: Attempt to install an assembly without a strong name
Package Review: https://bugzilla.redhat.com/show_bug.cgi?id=498873
P.S. If I'm being stupid and this is something which I need to address in the build process please let me know.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-509) C# Library Does Not Provide Strong
Name
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711427#action_12711427 ]
David Reiss commented on THRIFT-509:
------------------------------------
I think AC_PATH_PROG sets the variable to an empty string if the program is missing. We should disable csharp rather than aborting the build if gacutil is not installed. I don't suppose there is a text format for that .snk file. Is it customary to include private keys in the source tree?
> C# Library Does Not Provide Strong Name
> ---------------------------------------
>
> Key: THRIFT-509
> URL: https://issues.apache.org/jira/browse/THRIFT-509
> Project: Thrift
> Issue Type: Bug
> Components: Library (C#)
> Environment: Fedora 10 i386 - Mono version 2.0.1 - Thrift r770888
> Reporter: Silas Sewell
> Priority: Minor
> Attachments: 0001-THRIFT-509.-Add-strong-name-signing-and-GAC-installa.patch
>
>
> I'm in the process of having a Thrift package reviewed for Fedora. Unfortunately the C# library is failing to register because it thinks Thrift.dll doesn't provide a "strong name".
> If this is something that could be added to the library it would be very much appreciated.
> Error:
> DEBUG: + gacutil -i lib/csharp/Thrift.dll -f -package Thrift -root /builddir/build/BUILDROOT/thrift-0.0-0.fc10.20090501svn770888.i386/usr/lib
> DEBUG: Failure adding assembly lib/csharp/Thrift.dll to the cache: Attempt to install an assembly without a strong name
> Package Review: https://bugzilla.redhat.com/show_bug.cgi?id=498873
> P.S. If I'm being stupid and this is something which I need to address in the build process please let me know.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-509) C# Library Does Not Provide Strong
Name
Posted by "Silas Sewell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710279#action_12710279 ]
Silas Sewell commented on THRIFT-509:
-------------------------------------
That should work well for me.
> C# Library Does Not Provide Strong Name
> ---------------------------------------
>
> Key: THRIFT-509
> URL: https://issues.apache.org/jira/browse/THRIFT-509
> Project: Thrift
> Issue Type: Bug
> Components: Library (C#)
> Environment: Fedora 10 i386 - Mono version 2.0.1 - Thrift r770888
> Reporter: Silas Sewell
> Priority: Minor
> Attachments: 0001-THRIFT-509.-Add-strong-name-signing-and-GAC-installa.patch
>
>
> I'm in the process of having a Thrift package reviewed for Fedora. Unfortunately the C# library is failing to register because it thinks Thrift.dll doesn't provide a "strong name".
> If this is something that could be added to the library it would be very much appreciated.
> Error:
> DEBUG: + gacutil -i lib/csharp/Thrift.dll -f -package Thrift -root /builddir/build/BUILDROOT/thrift-0.0-0.fc10.20090501svn770888.i386/usr/lib
> DEBUG: Failure adding assembly lib/csharp/Thrift.dll to the cache: Attempt to install an assembly without a strong name
> Package Review: https://bugzilla.redhat.com/show_bug.cgi?id=498873
> P.S. If I'm being stupid and this is something which I need to address in the build process please let me know.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-509) C# Library Does Not Provide Strong
Name
Posted by "Jeff Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795244#action_12795244 ]
Jeff Brown commented on THRIFT-509:
-----------------------------------
I was thinking of submitting a patch for this myself and including a default .snk out of the box. Creating a strong-signed assembly is very useful for corporate clients and others downstream who wish to sign their own modules. Given that Thrift is OSS, clients can always choose to recompile the library with their own custom key if the provided well-known key isn't up to their standards.
> C# Library Does Not Provide Strong Name
> ---------------------------------------
>
> Key: THRIFT-509
> URL: https://issues.apache.org/jira/browse/THRIFT-509
> Project: Thrift
> Issue Type: Bug
> Components: Library (C#)
> Environment: Fedora 10 i386 - Mono version 2.0.1 - Thrift r770888
> Reporter: Silas Sewell
> Priority: Minor
> Attachments: 0001-THRIFT-509.-Add-strong-name-signing-and-GAC-installa-v2.patch, 0001-THRIFT-509.-Add-strong-name-signing-and-GAC-installa.patch
>
>
> I'm in the process of having a Thrift package reviewed for Fedora. Unfortunately the C# library is failing to register because it thinks Thrift.dll doesn't provide a "strong name".
> If this is something that could be added to the library it would be very much appreciated.
> Error:
> DEBUG: + gacutil -i lib/csharp/Thrift.dll -f -package Thrift -root /builddir/build/BUILDROOT/thrift-0.0-0.fc10.20090501svn770888.i386/usr/lib
> DEBUG: Failure adding assembly lib/csharp/Thrift.dll to the cache: Attempt to install an assembly without a strong name
> Package Review: https://bugzilla.redhat.com/show_bug.cgi?id=498873
> P.S. If I'm being stupid and this is something which I need to address in the build process please let me know.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-509) C# Library Does Not Provide Strong
Name
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated THRIFT-509:
----------------------------------
Attachment: 0001-THRIFT-509.-Add-strong-name-signing-and-GAC-installa.patch
There are a couple of ways to do this, and one could be addressed in your build process, but since other packagers are running into the same issue, I think it's best that we solve it here upstream.
This patch adds a strong name keyfile with public and private keys, adds an AssemblyInfo file for more explicit naming, and causes make and make install to sign the file and invoke gacutil, respectively.
Would this work for you?
> C# Library Does Not Provide Strong Name
> ---------------------------------------
>
> Key: THRIFT-509
> URL: https://issues.apache.org/jira/browse/THRIFT-509
> Project: Thrift
> Issue Type: Bug
> Components: Library (C#)
> Environment: Fedora 10 i386 - Mono version 2.0.1 - Thrift r770888
> Reporter: Silas Sewell
> Priority: Minor
> Attachments: 0001-THRIFT-509.-Add-strong-name-signing-and-GAC-installa.patch
>
>
> I'm in the process of having a Thrift package reviewed for Fedora. Unfortunately the C# library is failing to register because it thinks Thrift.dll doesn't provide a "strong name".
> If this is something that could be added to the library it would be very much appreciated.
> Error:
> DEBUG: + gacutil -i lib/csharp/Thrift.dll -f -package Thrift -root /builddir/build/BUILDROOT/thrift-0.0-0.fc10.20090501svn770888.i386/usr/lib
> DEBUG: Failure adding assembly lib/csharp/Thrift.dll to the cache: Attempt to install an assembly without a strong name
> Package Review: https://bugzilla.redhat.com/show_bug.cgi?id=498873
> P.S. If I'm being stupid and this is something which I need to address in the build process please let me know.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-509) C# Library Does Not Provide Strong
Name
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712231#action_12712231 ]
David Reiss commented on THRIFT-509:
------------------------------------
I guess I could go either way. It just seems silly to have a "private" key that is plastered all over the web.
> C# Library Does Not Provide Strong Name
> ---------------------------------------
>
> Key: THRIFT-509
> URL: https://issues.apache.org/jira/browse/THRIFT-509
> Project: Thrift
> Issue Type: Bug
> Components: Library (C#)
> Environment: Fedora 10 i386 - Mono version 2.0.1 - Thrift r770888
> Reporter: Silas Sewell
> Priority: Minor
> Attachments: 0001-THRIFT-509.-Add-strong-name-signing-and-GAC-installa-v2.patch, 0001-THRIFT-509.-Add-strong-name-signing-and-GAC-installa.patch
>
>
> I'm in the process of having a Thrift package reviewed for Fedora. Unfortunately the C# library is failing to register because it thinks Thrift.dll doesn't provide a "strong name".
> If this is something that could be added to the library it would be very much appreciated.
> Error:
> DEBUG: + gacutil -i lib/csharp/Thrift.dll -f -package Thrift -root /builddir/build/BUILDROOT/thrift-0.0-0.fc10.20090501svn770888.i386/usr/lib
> DEBUG: Failure adding assembly lib/csharp/Thrift.dll to the cache: Attempt to install an assembly without a strong name
> Package Review: https://bugzilla.redhat.com/show_bug.cgi?id=498873
> P.S. If I'm being stupid and this is something which I need to address in the build process please let me know.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-509) C# Library Does Not Provide Strong
Name
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated THRIFT-509:
----------------------------------
Attachment: 0001-THRIFT-509.-Add-strong-name-signing-and-GAC-installa-v2.patch
The .snk file only comes in binary form, sorry.
I can't say I really know whether it is customary to include private keys in the .snk in the source tree. Out of various notable open source .NET projects, Apache log4net and NHibernate, for instance, do not do it and require people to supply their own snk to build the release. The Rhino and Castle projects and Apache iBatis do include the snk. In a corporate environment the recommendation from Microsoft is to allow delayed-signing with individual developers leaving a build unsigned but still marked for signing, and a trusted authority signing the build. I'm not sure what makes sense for an open source project--who would be the keyholder? Is there a private, shared storage space at Apache for something like this?
This patch replaces the previous one should address the other issues you mention, following the style of the rest of the autoconf script.
> C# Library Does Not Provide Strong Name
> ---------------------------------------
>
> Key: THRIFT-509
> URL: https://issues.apache.org/jira/browse/THRIFT-509
> Project: Thrift
> Issue Type: Bug
> Components: Library (C#)
> Environment: Fedora 10 i386 - Mono version 2.0.1 - Thrift r770888
> Reporter: Silas Sewell
> Priority: Minor
> Attachments: 0001-THRIFT-509.-Add-strong-name-signing-and-GAC-installa-v2.patch, 0001-THRIFT-509.-Add-strong-name-signing-and-GAC-installa.patch
>
>
> I'm in the process of having a Thrift package reviewed for Fedora. Unfortunately the C# library is failing to register because it thinks Thrift.dll doesn't provide a "strong name".
> If this is something that could be added to the library it would be very much appreciated.
> Error:
> DEBUG: + gacutil -i lib/csharp/Thrift.dll -f -package Thrift -root /builddir/build/BUILDROOT/thrift-0.0-0.fc10.20090501svn770888.i386/usr/lib
> DEBUG: Failure adding assembly lib/csharp/Thrift.dll to the cache: Attempt to install an assembly without a strong name
> Package Review: https://bugzilla.redhat.com/show_bug.cgi?id=498873
> P.S. If I'm being stupid and this is something which I need to address in the build process please let me know.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-509) C# Library Does Not Provide Strong
Name
Posted by "James E. King, III (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896934#action_12896934 ]
James E. King, III commented on THRIFT-509:
-------------------------------------------
The C# runtime engine overhaul I did for THRIFT-66 includes strongly named assemblies.
> C# Library Does Not Provide Strong Name
> ---------------------------------------
>
> Key: THRIFT-509
> URL: https://issues.apache.org/jira/browse/THRIFT-509
> Project: Thrift
> Issue Type: Bug
> Components: Library (C#)
> Environment: Fedora 10 i386 - Mono version 2.0.1 - Thrift r770888
> Reporter: Silas Sewell
> Priority: Minor
> Attachments: 0001-THRIFT-509.-Add-strong-name-signing-and-GAC-installa-v2.patch, 0001-THRIFT-509.-Add-strong-name-signing-and-GAC-installa.patch
>
>
> I'm in the process of having a Thrift package reviewed for Fedora. Unfortunately the C# library is failing to register because it thinks Thrift.dll doesn't provide a "strong name".
> If this is something that could be added to the library it would be very much appreciated.
> Error:
> DEBUG: + gacutil -i lib/csharp/Thrift.dll -f -package Thrift -root /builddir/build/BUILDROOT/thrift-0.0-0.fc10.20090501svn770888.i386/usr/lib
> DEBUG: Failure adding assembly lib/csharp/Thrift.dll to the cache: Attempt to install an assembly without a strong name
> Package Review: https://bugzilla.redhat.com/show_bug.cgi?id=498873
> P.S. If I'm being stupid and this is something which I need to address in the build process please let me know.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-509) C# Library Does Not Provide Strong
Name
Posted by "Silas Sewell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740559#action_12740559 ]
Silas Sewell commented on THRIFT-509:
-------------------------------------
Any decision on this?
> C# Library Does Not Provide Strong Name
> ---------------------------------------
>
> Key: THRIFT-509
> URL: https://issues.apache.org/jira/browse/THRIFT-509
> Project: Thrift
> Issue Type: Bug
> Components: Library (C#)
> Environment: Fedora 10 i386 - Mono version 2.0.1 - Thrift r770888
> Reporter: Silas Sewell
> Priority: Minor
> Attachments: 0001-THRIFT-509.-Add-strong-name-signing-and-GAC-installa-v2.patch, 0001-THRIFT-509.-Add-strong-name-signing-and-GAC-installa.patch
>
>
> I'm in the process of having a Thrift package reviewed for Fedora. Unfortunately the C# library is failing to register because it thinks Thrift.dll doesn't provide a "strong name".
> If this is something that could be added to the library it would be very much appreciated.
> Error:
> DEBUG: + gacutil -i lib/csharp/Thrift.dll -f -package Thrift -root /builddir/build/BUILDROOT/thrift-0.0-0.fc10.20090501svn770888.i386/usr/lib
> DEBUG: Failure adding assembly lib/csharp/Thrift.dll to the cache: Attempt to install an assembly without a strong name
> Package Review: https://bugzilla.redhat.com/show_bug.cgi?id=498873
> P.S. If I'm being stupid and this is something which I need to address in the build process please let me know.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.