You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/23 18:59:25 UTC
[GitHub] [superset] justinpark opened a new pull request, #22209: fix(explore): undefined alteredControl value
justinpark opened a new pull request, #22209:
URL: https://github.com/apache/superset/pull/22209
### SUMMARY
Related to #20934 change, the following `props.controls[controlName].value` can be undefined when alteredControls are not existed on props.controls.
https://github.com/apache/superset/blob/888f43c6ad8444100cdcbf42c2ee0ae4f80c5ea3/superset-frontend/src/explore/components/ControlPanelsContainer.tsx#L278-L283
This commit fixes the following undefined property access error due to this change.
```
react-dom.production.min.js:209 TypeError: Cannot read properties of undefined (reading 'value')
at ControlPanelsContainer.tsx:282:39
at Array.forEach (<anonymous>)
at ControlPanelsContainer.tsx:280:28
at il (react-dom.production.min.js:211:320)
```
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
<img width="1678" alt="image (9)" src="https://user-images.githubusercontent.com/1392866/203626623-1ccfcfd2-b87c-40aa-9537-53be0ce0df23.png">
After:
N/A
### TESTING INSTRUCTIONS
- click Create Chart in SQL Lab, it opens the explore view
- runs the query by default
- that query finished running is when I got this error and the UI broke
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
cc: @ktmud @john-bodley
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #22209: fix(explore): undefined alteredControl value
Posted by GitBox <gi...@apache.org>.
villebro commented on PR #22209:
URL: https://github.com/apache/superset/pull/22209#issuecomment-1325573980
@justinpark @kgabryje is this a duplicate of #22207?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on pull request #22209: fix(explore): undefined alteredControl value
Posted by GitBox <gi...@apache.org>.
justinpark commented on PR #22209:
URL: https://github.com/apache/superset/pull/22209#issuecomment-1325586153
closed as duplicates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #22209: fix(explore): undefined alteredControl value
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22209:
URL: https://github.com/apache/superset/pull/22209#issuecomment-1325535961
# [Codecov](https://codecov.io/gh/apache/superset/pull/22209?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22209](https://codecov.io/gh/apache/superset/pull/22209?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (888f43c) into [master](https://codecov.io/gh/apache/superset/commit/888f43c6ad8444100cdcbf42c2ee0ae4f80c5ea3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (888f43c) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 888f43c differs from pull request most recent head 35e8adf. Consider uploading reports for the commit 35e8adf to get more accurate results
```diff
@@ Coverage Diff @@
## master #22209 +/- ##
=======================================
Coverage 66.96% 66.96%
=======================================
Files 1835 1835
Lines 69927 69927
Branches 7590 7590
=======================================
Hits 46826 46826
Misses 21135 21135
Partials 1966 1966
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.57% <0.00%> (ø)` | |
| javascript | `53.80% <0.00%> (ø)` | |
| mysql | `78.08% <0.00%> (ø)` | |
| postgres | `78.15% <0.00%> (ø)` | |
| presto | `52.47% <0.00%> (ø)` | |
| python | `81.33% <0.00%> (ø)` | |
| sqlite | `76.60% <0.00%> (ø)` | |
| unit | `50.86% <0.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark closed pull request #22209: fix(explore): undefined alteredControl value
Posted by GitBox <gi...@apache.org>.
justinpark closed pull request #22209: fix(explore): undefined alteredControl value
URL: https://github.com/apache/superset/pull/22209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org