You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/05/28 23:58:00 UTC
[Impala-ASF-CR] IMPALA-9737: fix reservation accounting bug in PHJ
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15958
Change subject: IMPALA-9737: fix reservation accounting bug in PHJ
......................................................................
IMPALA-9737: fix reservation accounting bug in PHJ
This bug would only impact spilling queries with
mt_dop > 0, where there is a separate builder and
reservation needs to be transferred back to the builder.
The bug was that 'probe_batch_' could own buffers that
were using reservation from the PartitionedHashJoinNode.
This reservation needs to be transferred back to the
PartitionedHashJoinBuilder via ReturnReservation(). Therefore
we need to clean up the batches before calling ReturnReservation().
Change-Id: Ia1619ad642628b64ed57e6f85e0755a128bafdb5
---
M be/src/exec/partitioned-hash-join-node.cc
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/15958/2
--
To view, visit http://gerrit.cloudera.org:8080/15958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1619ad642628b64ed57e6f85e0755a128bafdb5
Gerrit-Change-Number: 15958
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9737: fix reservation accounting bug in PHJ
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15958 )
Change subject: IMPALA-9737: fix reservation accounting bug in PHJ
......................................................................
Patch Set 2:
I couldn't reproduce this bug at all locally, I think it was probably very timing or data-dependent.
--
To view, visit http://gerrit.cloudera.org:8080/15958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1619ad642628b64ed57e6f85e0755a128bafdb5
Gerrit-Change-Number: 15958
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 May 2020 23:58:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9737: fix reservation accounting bug in PHJ
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15958 )
Change subject: IMPALA-9737: fix reservation accounting bug in PHJ
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1619ad642628b64ed57e6f85e0755a128bafdb5
Gerrit-Change-Number: 15958
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 May 2020 12:08:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9737: fix reservation accounting bug in PHJ
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15958 )
Change subject: IMPALA-9737: fix reservation accounting bug in PHJ
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6155/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1619ad642628b64ed57e6f85e0755a128bafdb5
Gerrit-Change-Number: 15958
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 May 2020 00:49:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9737: fix reservation accounting bug in PHJ
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15958 )
Change subject: IMPALA-9737: fix reservation accounting bug in PHJ
......................................................................
IMPALA-9737: fix reservation accounting bug in PHJ
This bug would only impact spilling queries with
mt_dop > 0, where there is a separate builder and
reservation needs to be transferred back to the builder.
The bug was that 'probe_batch_' could own buffers that
were using reservation from the PartitionedHashJoinNode.
This reservation needs to be transferred back to the
PartitionedHashJoinBuilder via ReturnReservation(). Therefore
we need to clean up the batches before calling ReturnReservation().
Change-Id: Ia1619ad642628b64ed57e6f85e0755a128bafdb5
Reviewed-on: http://gerrit.cloudera.org:8080/15958
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
---
M be/src/exec/partitioned-hash-join-node.cc
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Csaba Ringhofer: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1619ad642628b64ed57e6f85e0755a128bafdb5
Gerrit-Change-Number: 15958
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>