[jira] [Commented] (THRIFT-1846) Restore socket.h header to support builds with Android NDK

["Nicolas Trésegnie (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576236#comment-13576236 ] 

Nicolas Trésegnie commented on THRIFT-1846:
-------------------------------------------

In the Android NDK, there is a missing include in un.h, that's why [~nater] got an error. Before THRIFT-1740, socket.h was included before un.h as a workaround (or maybe juste by chance).

The socket.h should be re-added to the .cpp and also removed from the .h to avoid hidden dependencies. If it's a problem when building for iOS, whe should discuss it.
                
> Restore socket.h header to support builds with Android NDK
> ----------------------------------------------------------
>
>                 Key: THRIFT-1846
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1846
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9
>         Environment: Building with Android Linux NDK R8D (and, it looks like, all previous NDKs)
>            Reporter: Nate Rosenblum
>             Fix For: 0.9
>
>         Attachments: 0001-Restore-socket.h-include-to-support-Android-builds.patch
>
>
> Unlike every other rational un.h that I've seen, the sys/un.h (actually linux/un.h) distributed with the Android NDK doesn't define sa_family_t or include another header that does. Removal of socket.h in THRIFT-1740 broke the Android build.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira