You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by "Roger Whitcomb (JIRA)" <ji...@apache.org> on 2011/06/21 20:45:47 UTC
[jira] [Created] (PIVOT-762) Incorrect handling of TAB key in
SuggestionPopup
Incorrect handling of TAB key in SuggestionPopup
------------------------------------------------
Key: PIVOT-762
URL: https://issues.apache.org/jira/browse/PIVOT-762
Project: Pivot
Issue Type: Bug
Components: wtk-terra
Affects Versions: 2.0.1
Environment: Windows XP SP3, JRE 1.7 beta
Reporter: Roger Whitcomb
Priority: Minor
Fix For: 2.0.1
It appears the TAB key handling inside SuggestionPopup either doesn't work at all to transfer focus or it tries to transfer and then transfers back to the TextInput.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-762) Incorrect handling of TAB key in
SuggestionPopup
Posted by "Roger Whitcomb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053410#comment-13053410 ]
Roger Whitcomb commented on PIVOT-762:
--------------------------------------
Committed revision 1138592.
> Incorrect handling of TAB key in SuggestionPopup
> ------------------------------------------------
>
> Key: PIVOT-762
> URL: https://issues.apache.org/jira/browse/PIVOT-762
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0.1
> Environment: Windows XP SP3, JRE 1.7 beta
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: suggest.patch, suggest2.patch, suggestion_popup_test.bxml
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> It appears the TAB key handling inside SuggestionPopup either doesn't work at all to transfer focus or it tries to transfer and then transfers back to the TextInput.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-762) Incorrect handling of TAB key in
SuggestionPopup
Posted by "Chris Bartlett (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Bartlett updated PIVOT-762:
---------------------------------
Attachment: suggestion_popup_test.bxml
> Incorrect handling of TAB key in SuggestionPopup
> ------------------------------------------------
>
> Key: PIVOT-762
> URL: https://issues.apache.org/jira/browse/PIVOT-762
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0.1
> Environment: Windows XP SP3, JRE 1.7 beta
> Reporter: Roger Whitcomb
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: suggest.patch, suggestion_popup_test.bxml
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> It appears the TAB key handling inside SuggestionPopup either doesn't work at all to transfer focus or it tries to transfer and then transfers back to the TextInput.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (PIVOT-762) Incorrect handling of TAB key in
SuggestionPopup
Posted by "Roger Whitcomb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Whitcomb reassigned PIVOT-762:
------------------------------------
Assignee: Roger Whitcomb
> Incorrect handling of TAB key in SuggestionPopup
> ------------------------------------------------
>
> Key: PIVOT-762
> URL: https://issues.apache.org/jira/browse/PIVOT-762
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0.1
> Environment: Windows XP SP3, JRE 1.7 beta
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: suggest.patch, suggest2.patch, suggestion_popup_test.bxml
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> It appears the TAB key handling inside SuggestionPopup either doesn't work at all to transfer focus or it tries to transfer and then transfers back to the TextInput.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-762) Incorrect handling of TAB key in
SuggestionPopup
Posted by "Roger Whitcomb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Whitcomb updated PIVOT-762:
---------------------------------
Attachment: suggest2.patch
Updated patch with just the TAB/SHIFT-TAB handling straightened out.
> Incorrect handling of TAB key in SuggestionPopup
> ------------------------------------------------
>
> Key: PIVOT-762
> URL: https://issues.apache.org/jira/browse/PIVOT-762
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0.1
> Environment: Windows XP SP3, JRE 1.7 beta
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: suggest.patch, suggest2.patch, suggestion_popup_test.bxml
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> It appears the TAB key handling inside SuggestionPopup either doesn't work at all to transfer focus or it tries to transfer and then transfers back to the TextInput.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-762) Incorrect handling of TAB key in
SuggestionPopup
Posted by "Roger Whitcomb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Whitcomb updated PIVOT-762:
---------------------------------
Attachment: suggest.patch
This patch seems to work for my test case.
> Incorrect handling of TAB key in SuggestionPopup
> ------------------------------------------------
>
> Key: PIVOT-762
> URL: https://issues.apache.org/jira/browse/PIVOT-762
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0.1
> Environment: Windows XP SP3, JRE 1.7 beta
> Reporter: Roger Whitcomb
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: suggest.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> It appears the TAB key handling inside SuggestionPopup either doesn't work at all to transfer focus or it tries to transfer and then transfers back to the TextInput.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PIVOT-762) Incorrect handling of TAB key in
SuggestionPopup
Posted by "Roger Whitcomb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Whitcomb resolved PIVOT-762.
----------------------------------
Resolution: Fixed
There are some ancillary issues which are/will be covered by other tickets. I believe this commit fixes the Tab/Shift-Tab issues for SuggestionPopup.
> Incorrect handling of TAB key in SuggestionPopup
> ------------------------------------------------
>
> Key: PIVOT-762
> URL: https://issues.apache.org/jira/browse/PIVOT-762
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0.1
> Environment: Windows XP SP3, JRE 1.7 beta
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: suggest.patch, suggest2.patch, suggestion_popup_test.bxml
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> It appears the TAB key handling inside SuggestionPopup either doesn't work at all to transfer focus or it tries to transfer and then transfers back to the TextInput.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-762) Incorrect handling of TAB key in
SuggestionPopup
Posted by "Chris Bartlett (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053210#comment-13053210 ]
Chris Bartlett commented on PIVOT-762:
--------------------------------------
Modified BXML file to simplify testing with http://svn.apache.org/repos/asf/pivot/trunk/tests/src/org/apache/pivot/tests/SuggestionPopupTest.java
> Incorrect handling of TAB key in SuggestionPopup
> ------------------------------------------------
>
> Key: PIVOT-762
> URL: https://issues.apache.org/jira/browse/PIVOT-762
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0.1
> Environment: Windows XP SP3, JRE 1.7 beta
> Reporter: Roger Whitcomb
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: suggest.patch, suggestion_popup_test.bxml
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> It appears the TAB key handling inside SuggestionPopup either doesn't work at all to transfer focus or it tries to transfer and then transfers back to the TextInput.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-762) Incorrect handling of TAB key in
SuggestionPopup
Posted by "Chris Bartlett (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053208#comment-13053208 ]
Chris Bartlett commented on PIVOT-762:
--------------------------------------
The patch looks fine to me for transferring focus TAB and SHIFT+TAB.
Tested using
http://svn.apache.org/repos/asf/pivot/trunk/tests/src/org/apache/pivot/tests/SuggestionPopupTest.java
and a slightly modified version of its BXML file (attached).
> Incorrect handling of TAB key in SuggestionPopup
> ------------------------------------------------
>
> Key: PIVOT-762
> URL: https://issues.apache.org/jira/browse/PIVOT-762
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0.1
> Environment: Windows XP SP3, JRE 1.7 beta
> Reporter: Roger Whitcomb
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: suggest.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> It appears the TAB key handling inside SuggestionPopup either doesn't work at all to transfer focus or it tries to transfer and then transfers back to the TextInput.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira