You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (JIRA)" <ji...@apache.org> on 2012/12/10 11:39:21 UTC
[jira] [Commented] (QPID-4496) [JMS] Improve error reporting for
invalid addresses
[ https://issues.apache.org/jira/browse/QPID-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527862#comment-13527862 ]
Robbie Gemmell commented on QPID-4496:
--------------------------------------
Regarding http://svn.apache.org/viewvc?view=revision&revision=1418539
There is a typo in the spelling of Assert in the new exceptions. Can we respect the code style and not have if statements on a single line and without braces?
The swapping of the assert and create operation ordering seems reasonable, since create implicitly asserts and if you had requested both previously it presumably wouldnt have actually created given the prior ordering.
This seems like a change that should have tests?
Robbie
> [JMS] Improve error reporting for invalid addresses
> ---------------------------------------------------
>
> Key: QPID-4496
> URL: https://issues.apache.org/jira/browse/QPID-4496
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.18, 0.20
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Labels: addressing, jms
> Fix For: 0.21
>
>
> In the following example, the second address should throw an exception notifying that the request type is different from the already present object
> 1. java -cp ${CLASSPATH} org.apache.qpid.example.Spout "ex;{create:sender, node: {type:topic,x-declare:{type:topic}}}"
> 2. java -cp ${CLASSPATH} org.apache.qpid.example.Spout "ex;{create:sender, node: {type:topic,x-declare:{type:fanout}}}"
> Also we need to provide a clear messages when an assertion is false.
> Ex.
> 1. java -cp ${CLASSPATH} org.apache.qpid.example.Spout "ex;{create:sender, node: {type:topic,x-declare:{type:topic}}}"
> 2. java -cp ${CLASSPATH} org.apache.qpid.example.Spout "ex;{assert:sender, node: {type:topic,x-declare:{type:fanout}}}"
> All though we currently throw an exception, the message is not very useful.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org