You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "jamesnetherton (via GitHub)" <gi...@apache.org> on 2023/06/28 09:42:13 UTC
[GitHub] [camel-quarkus] jamesnetherton opened a new pull request, #5021: Remove reserve-network-port execution for integration tests
jamesnetherton opened a new pull request, #5021:
URL: https://github.com/apache/camel-quarkus/pull/5021
Motivation:
* AFAIK no other project in the Quarkus ecosystem does this
* Avoids having another mojo execution in the build and allocating 250+ ports
* It would probably fix #4988
Let's see how the CI build goes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #5021: Remove reserve-network-port execution for integration tests
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #5021:
URL: https://github.com/apache/camel-quarkus/pull/5021#issuecomment-1611441059
> It's used in the performance regression too
Yeah, I did see that. I was not sure if the perf bits required a random port so I left it as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #5021: Remove reserve-network-port execution for integration tests
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on PR #5021:
URL: https://github.com/apache/camel-quarkus/pull/5021#issuecomment-1611476858
The perf tool might generate a sample project that needs a random port when run.
As the ci is green, the sample-project might not used build-parent-it. That should be ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #5021: Remove reserve-network-port execution for integration tests
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton merged PR #5021:
URL: https://github.com/apache/camel-quarkus/pull/5021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #5021: Remove reserve-network-port execution for integration tests
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on PR #5021:
URL: https://github.com/apache/camel-quarkus/pull/5021#issuecomment-1611132044
It's used in the performance regression tool:
https://github.com/apache/camel-quarkus/blob/f1434577fc270c55b06e64a47d872bc381336150/tooling/perf-regression/cq-perf-regression-sample-base/pom.xml#L119
Not sure about the impact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org