You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/09/05 10:15:57 UTC
[GitHub] [inlong] healchow commented on a diff in pull request #5684: [INLONG-5666][SortStandalone] SortSdkSource supports init multiple Sort SDK to improve performance
healchow commented on code in PR #5684:
URL: https://github.com/apache/inlong/pull/5684#discussion_r962741168
##########
inlong-sort-standalone/sort-standalone-source/src/main/java/org/apache/inlong/sort/standalone/source/sortsdk/SortSdkSource.java:
##########
@@ -249,14 +257,18 @@ private Map<String, String> getSortClientConfigParameters() {
*/
@Override
public void stopConsumer() {
- sortClient.getConfig().setStopConsume(true);
+ for (SortClient sortClient : sortClients) {
+ sortClient.getConfig().setStopConsume(true);
+ }
}
/**
* recoverConsumer
*/
@Override
public void recoverConsumer() {
- sortClient.getConfig().setStopConsume(false);
+ for (SortClient sortClient : sortClients) {
+ sortClient.getConfig().setStopConsume(false);
+ }
}
-}
+}
Review Comment:
No need to delete the blank line at the end of the file, otherwise there is a symble in GitHub.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org