You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@opennlp.apache.org by "reckart (via GitHub)" <gi...@apache.org> on 2023/04/20 20:31:26 UTC

[GitHub] [opennlp-sandbox] reckart commented on pull request #101: OPENNLP-1454 Convert System.out statements to debug logging statements in 'opennlp-similarity'

reckart commented on PR #101:
URL: https://github.com/apache/opennlp-sandbox/pull/101#issuecomment-1516908800

   > introduces log4j-2.x as (managed) runtime binding for slj4j in opennlp-similarity
   
   I didn't see the binding being added in the runtime scope in the changes - however, it should not be added as a runtime dependency because afaik runtime dependencies are transitive - and logging implementations should never be part of the transitive dependency graph.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org