You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org> on 2007/09/01 19:25:19 UTC
[jira] Commented: (TAPESTRY-1730) Order of event handler method
invocation should be greatest number of parameters to fewest
[ https://issues.apache.org/jira/browse/TAPESTRY-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524290 ]
Howard M. Lewis Ship commented on TAPESTRY-1730:
------------------------------------------------
The workaround is to have a single onActivate() method that takes Object[]:
void onActivate(Object[] context) {
if (context.length != 1) return _invalidAuthorizationPage;
String token = (String) context[0];
// validate token
return null; // token is ok
}
> Order of event handler method invocation should be greatest number of parameters to fewest
> ------------------------------------------------------------------------------------------
>
> Key: TAPESTRY-1730
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1730
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.0.5
> Reporter: Howard M. Lewis Ship
>
> Say you are writing an activate event handler, meant to guard the page against access without a provided token.
> void onActivate(String token) {
> // validate the token
> }
> Object onPassivate() { return _token; }
> Great ... but what about the case where the user omits the token?
> Object onActivate() {
> return _invalidAuthorizationPage; // Redirect away
> }
> But with the current setup, this gets invoked BEFORE onActivate(String) so there's no hope of actually using the page, even with the security token.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org