You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rayees Namathponnan <ra...@citrix.com> on 2014/07/23 09:58:37 UTC

Failed add KVM agent to CS with latest master

I am unable to add KVM agent with latest master build,  this issue is tracked in https://issues.apache.org/jira/browse/CLOUDSTACK-7170

Those made changes in master yesterday/today, can you please check it regressed from you commit or not ?

Regards,
Rayees

Re: Failed add KVM agent to CS with latest master

Posted by Daan Hoogland <da...@gmail.com>.
I saw them coming in, great work. Let's hope the ones that caused the
issue will trigger people to find the root cause this time.

On Fri, Jul 25, 2014 at 2:28 PM, Santhosh Edukulla
<sa...@citrix.com> wrote:
> I just pushed individual commits, so all should be in.
>
> Santhosh
> ________________________________________
> From: Santhosh Edukulla
> Sent: Thursday, July 24, 2014 5:05 AM
> To: dev@cloudstack.apache.org; Santhosh Edukulla
> Subject: RE: Failed add KVM agent to CS with latest master
>
> Agree. I decided to split it into multiple smaller ones going ahead.   Instead of revert, may be we would have identified root cause and helped to fix the issue.
>
> Santhosh
> ________________________________________
> From: Daan Hoogland [daan.hoogland@gmail.com]
> Sent: Thursday, July 24, 2014 4:57 AM
> To: dev; Santhosh Edukulla
> Subject: Re: Failed add KVM agent to CS with latest master
>
> On Thu, Jul 24, 2014 at 12:12 AM, Amogh Vasekar
> <am...@citrix.com> wrote:
>> 4523490d44160b054de9e943f72db1d0ce06054a
>
> Another big coverity fix reverted Santhosh. Could you split this one
> as well. A shame if all that work is getting lost this way.
>
>
> --
> Daan



-- 
Daan

RE: Failed add KVM agent to CS with latest master

Posted by Santhosh Edukulla <sa...@citrix.com>.
I just pushed individual commits, so all should be in.

Santhosh
________________________________________
From: Santhosh Edukulla
Sent: Thursday, July 24, 2014 5:05 AM
To: dev@cloudstack.apache.org; Santhosh Edukulla
Subject: RE: Failed add KVM agent to CS with latest master

Agree. I decided to split it into multiple smaller ones going ahead.   Instead of revert, may be we would have identified root cause and helped to fix the issue.

Santhosh
________________________________________
From: Daan Hoogland [daan.hoogland@gmail.com]
Sent: Thursday, July 24, 2014 4:57 AM
To: dev; Santhosh Edukulla
Subject: Re: Failed add KVM agent to CS with latest master

On Thu, Jul 24, 2014 at 12:12 AM, Amogh Vasekar
<am...@citrix.com> wrote:
> 4523490d44160b054de9e943f72db1d0ce06054a

Another big coverity fix reverted Santhosh. Could you split this one
as well. A shame if all that work is getting lost this way.


--
Daan

RE: Failed add KVM agent to CS with latest master

Posted by Santhosh Edukulla <sa...@citrix.com>.
Agree. I decided to split it into multiple smaller ones going ahead.   Instead of revert, may be we would have identified root cause and helped to fix the issue. 

Santhosh
________________________________________
From: Daan Hoogland [daan.hoogland@gmail.com]
Sent: Thursday, July 24, 2014 4:57 AM
To: dev; Santhosh Edukulla
Subject: Re: Failed add KVM agent to CS with latest master

On Thu, Jul 24, 2014 at 12:12 AM, Amogh Vasekar
<am...@citrix.com> wrote:
> 4523490d44160b054de9e943f72db1d0ce06054a

Another big coverity fix reverted Santhosh. Could you split this one
as well. A shame if all that work is getting lost this way.


--
Daan

Re: Failed add KVM agent to CS with latest master

Posted by Daan Hoogland <da...@gmail.com>.
On Thu, Jul 24, 2014 at 12:12 AM, Amogh Vasekar
<am...@citrix.com> wrote:
> 4523490d44160b054de9e943f72db1d0ce06054a

Another big coverity fix reverted Santhosh. Could you split this one
as well. A shame if all that work is getting lost this way.


-- 
Daan

Re: Failed add KVM agent to CS with latest master

Posted by Amogh Vasekar <am...@citrix.com>.
Reverted the offending commit 4523490d44160b054de9e943f72db1d0ce06054a,
should work now.

Thanks,
Amogh

On 7/23/14 5:40 AM, "Alex Brett" <Al...@citrix.com> wrote:

>> I am unable to add KVM agent with latest master build,  this issue is
>>tracked
>> in https://issues.apache.org/jira/browse/CLOUDSTACK-7170
>> 
>> Those made changes in master yesterday/today, can you please check it
>> regressed from you commit or not ?
>
>As noted on the ticket I've narrowed this down to one of the following
>three changesets:
>
>commit 3b32732459730bfd4848678c95c27e2eb653cc04
>Author: Min Chen <mi...@citrix.com>
>Date:   Tue Jul 22 09:47:27 2014 -0700
>
>    CLOUDSTACK-7162:queryAsyncJobResult api does not return jobinstanceid.
>
>commit 1d2124dcbf48d15d23ddbdea23a29f0ab21be6f3
>Author: Hugo Trippaers <ht...@schubergphilis.com>
>Date:   Tue Jul 22 17:43:49 2014 +0200
>
>    Fix NPE reported on IRC, provide the user an informative error message
>
>commit 4523490d44160b054de9e943f72db1d0ce06054a
>Author: Santhosh Edukulla <sa...@gmail.com>
>Date:   Mon Jul 21 20:49:03 2014 +0530
>
>    Fixed Coverity Issues reported
>    
>    Signed-off-by: Santhosh Edukulla <sa...@gmail.com>
>
>Alex


RE: Failed add KVM agent to CS with latest master

Posted by Alex Brett <Al...@citrix.com>.
> I am unable to add KVM agent with latest master build,  this issue is tracked
> in https://issues.apache.org/jira/browse/CLOUDSTACK-7170
> 
> Those made changes in master yesterday/today, can you please check it
> regressed from you commit or not ?

As noted on the ticket I've narrowed this down to one of the following three changesets:

commit 3b32732459730bfd4848678c95c27e2eb653cc04
Author: Min Chen <mi...@citrix.com>
Date:   Tue Jul 22 09:47:27 2014 -0700

    CLOUDSTACK-7162:queryAsyncJobResult api does not return jobinstanceid.

commit 1d2124dcbf48d15d23ddbdea23a29f0ab21be6f3
Author: Hugo Trippaers <ht...@schubergphilis.com>
Date:   Tue Jul 22 17:43:49 2014 +0200

    Fix NPE reported on IRC, provide the user an informative error message

commit 4523490d44160b054de9e943f72db1d0ce06054a
Author: Santhosh Edukulla <sa...@gmail.com>
Date:   Mon Jul 21 20:49:03 2014 +0530

    Fixed Coverity Issues reported
    
    Signed-off-by: Santhosh Edukulla <sa...@gmail.com>

Alex