[jira] [Updated] (PIG-4734) TOMAP schema inferring breaks some scripts in type checking for bincond

["Daniel Dai (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PIG-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-4734:
----------------------------
    Attachment: PIG-4734-2.patch

Use a restrictive way to do the check. GenerateMapFloat is no special in terms of type checking. I manually verified it works. I tend not to include it in the case since most of the code there is not related to the case. Is that Ok>

> TOMAP schema inferring breaks some scripts in type checking for bincond
> -----------------------------------------------------------------------
>
>                 Key: PIG-4734
>                 URL: https://issues.apache.org/jira/browse/PIG-4734
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Rohini Palaniswamy
>            Assignee: Daniel Dai
>             Fix For: 0.16.0, 0.15.1
>
>         Attachments: PIG-4734-1.patch, PIG-4734-2.patch
>
>
> PIG-4674 added schema inferring for TOMAP.
> {code}
> FOREACH A GENERATE (val == 'x' ? TOMAP('key', floatfield1) : (val == 'y' ? GenerateFloatMap('key', floatfield2) : NULL)) as floatmap:map[float],
> {code}
> The following line fails with
> {code}
> Two inputs of BinCond must have compatible schemas. left hand side: #675:map(#676:float) right hand side: #801:map
> 	at org.apache.pig.newplan.logical.visitor.TypeCheckingExpVisitor.visit(TypeCheckingExpVisitor.java:616)
> 	... 45 more
> {code}
> GenerateFloatMap is a UDF that returns new HashMap<String, Float>(), but does not have outputSchema() defined. It worked earlier because TOMAP also did not have outputSchema() defined.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)