[GitHub] [skywalking] kezhenxu94 edited a comment on issue #6901: Allow multiple definitions as fallback in `metadata-service-mapping.yaml` file

[GitBox <gi...@apache.org>]

kezhenxu94 edited a comment on issue #6901:
URL: https://github.com/apache/skywalking/issues/6901#issuecomment-839841521


   > The config file would look like this:
   > 
   > ```yaml
   > serviceName: ${LABELS."service.istio.io/canonical-name"},${LABELS."app.kubernetes.io/name"},${LABELS."app"}
   > serviceInstanceName: ${NAME}
   > ```
   > 
   > This is just a suggestion, any other implementation covering the requirement is welcome.
   
   Instead of `${a},${b},${c}`, I used `${a,b,c}` in #6933 , so something like `prefix::${a,b,c}::suffix` will work if `a` is empty but `b` is not (say `test`), it evaluates as `prefix::test::suffix`, using `${a},${b},${c}` will need to duplicate the prefixes and suffixes like `prefix::${a}::suffix,prefix::${b}::suffix,prefix::${c}::suffix`, and the empty check is even complicated since `a == null` evaluates `prefix::${a}::suffix` as `prefix::null::suffix`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org