[GitHub] [pinot] deemoliu commented on a diff in pull request #10052: Add an API to download validDocIdsSnapshots from peer servers

[GitBox <gi...@apache.org>]

deemoliu commented on code in PR #10052:
URL: https://github.com/apache/pinot/pull/10052#discussion_r1063933449


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentImpl.java:
##########
@@ -150,7 +150,7 @@ public void deleteValidDocIdsSnapshot() {
     }
   }
 
-  private File getValidDocIdsSnapshotFile() {
+  public File getValidDocIdsSnapshotFile() {

Review Comment:
   thanks @Jackie-Jiang for review. since getValidDocIdsSnapshotFile() is not being called, i revert this change back.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org