You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/30 20:23:45 UTC
[GitHub] [airflow] NadimYounes opened a new issue #12722: No Support for special Characters in Passwords for get_uri() method in DbApiHook
NadimYounes opened a new issue #12722:
URL: https://github.com/apache/airflow/issues/12722
Hello,
I have recently noticed that a lot of connections with certain special characters don't work with SqlAlchemy as it requires the passwords to be [urlencoded when they contain special characters](https://stackoverflow.com/questions/1423804/writing-a-connection-string-when-password-contains-special-characters).
Would there be any impact to changing the code at line 81 to urlencode the password like `urllib.parse.quote_plus(conn.password)` to prevent login failures for special characters?
https://github.com/apache/airflow/blob/dee304b222d355b03794aa063f39e3ee13997730/airflow/hooks/dbapi_hook.py#L81
I initially caught this issue while using the OdbcHook method found here. https://github.com/apache/airflow/blob/dee304b222d355b03794aa063f39e3ee13997730/airflow/providers/odbc/hooks/odbc.py#L198
Happy to create a feature request, I just want to confirm that this issue makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #12722: No Support for special Characters in Passwords for get_uri() method in DbApiHook
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #12722:
URL: https://github.com/apache/airflow/issues/12722#issuecomment-736021538
Thanks for opening your first issue here! Be sure to follow the issue template!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alokshenoy commented on issue #12722: No Support for special Characters in Passwords for get_uri() method in DbApiHook
Posted by GitBox <gi...@apache.org>.
alokshenoy commented on issue #12722:
URL: https://github.com/apache/airflow/issues/12722#issuecomment-737373754
Experience this last night while testing something. If it's still unassigned, I'd like to take this up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #12722: No Support for special Characters in Passwords for get_uri() method in DbApiHook
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #12722:
URL: https://github.com/apache/airflow/issues/12722#issuecomment-736410787
> Happy to create a feature request, I just want to confirm that this issue makes sense.
Go ahead. It makes a lot of sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #12722: No Support for special Characters in Passwords for get_uri() method in DbApiHook
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #12722:
URL: https://github.com/apache/airflow/issues/12722#issuecomment-737377873
@alokshenoy I assigned you to this ticket 🐈⬛ 🐈
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alokshenoy edited a comment on issue #12722: No Support for special Characters in Passwords for get_uri() method in DbApiHook
Posted by GitBox <gi...@apache.org>.
alokshenoy edited a comment on issue #12722:
URL: https://github.com/apache/airflow/issues/12722#issuecomment-737373754
Experienced this last night while testing something. If it's still unassigned, I'd like to take this up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj closed issue #12722: No Support for special Characters in Passwords for get_uri() method in DbApiHook
Posted by GitBox <gi...@apache.org>.
mik-laj closed issue #12722:
URL: https://github.com/apache/airflow/issues/12722
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] NadimYounes commented on issue #12722: No Support for special Characters in Passwords for get_uri() method in DbApiHook
Posted by GitBox <gi...@apache.org>.
NadimYounes commented on issue #12722:
URL: https://github.com/apache/airflow/issues/12722#issuecomment-737435260
@alokshenoy please go for it, I am super busy the next few weeks, thanks for taking this up. @alokshenoy can you please tag me on the PR or ticket so I can just follow it?
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org