You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/25 14:16:13 UTC

[GitHub] [incubator-nuttx] govindsi opened a new pull request #3780: k210 risc-v 

govindsi opened a new pull request #3780:
URL: https://github.com/apache/incubator-nuttx/pull/3780


   ## Summary
   1) Update README.txt with updated clone path.
   2) arch/riscv/bl602: Fix typo in i2c driver.
   3) Add all supported external PLC irq no's for k210 to add support for more peripherals.
   4) Minor fix in k210 gpio driver to check max hs gpio no.
   
   ## Impact
   Minimal.
   
   ## Testing
   Tested on k210 maix-bit board.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #3780: k210 risc-v

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3780:
URL: https://github.com/apache/incubator-nuttx/pull/3780#issuecomment-847971293


   Hi @govindsi it is reporting too many blank lines in your file:
   
   Error: nuttx/arch/risc-v/src/k210/k210_gpiohs.c:74:1: error: Too many blank lines.
   
   Also there are some issues in the files:
   
   
   chip/k210_gpiohs.c: In function 'k210_gpiohs_set_direction':
   Error: chip/k210_gpiohs.c:62:7: error: 'gpio' undeclared (first use in this function); did you mean 'io'?
      if (gpio >= K210_NGPIOHS)
          ^~~~
          io
   chip/k210_gpiohs.c:62:7: note: each undeclared identifier is reported only once for each function it appears in
   chip/k210_gpiohs.c: In function 'k210_gpiohs_set_value':
   Error: chip/k210_gpiohs.c:75:7: error: 'gpio' undeclared (first use in this function); did you mean 'io'?
      if (gpio >= K210_NGPIOHS)
          ^~~~
          io
   chip/k210_gpiohs.c: In function 'k210_gpiohs_get_value':
   Error: chip/k210_gpiohs.c:85:3: error: implicit declaration of function 'DEBUGASSERT' [-Werror=implicit-function-declaration]
      DEBUGASSERT(io >= 0 && pin <= K210_NGPIOHS);
      ^~~~~~~~~~~
   Error: chip/k210_gpiohs.c:85:26: error: 'pin' undeclared (first use in this function)
      DEBUGASSERT(io >= 0 && pin <= K210_NGPIOHS);
                             ^~~
   
   Probably you forgot to include debug.h thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] govindsi commented on pull request #3780: k210 risc-v

Posted by GitBox <gi...@apache.org>.
govindsi commented on pull request #3780:
URL: https://github.com/apache/incubator-nuttx/pull/3780#issuecomment-848073394


   Hi Alan,
   My bad, i missed to amend the changes. I will raise another pull req.
   
   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] govindsi closed pull request #3780: k210 risc-v

Posted by GitBox <gi...@apache.org>.
govindsi closed pull request #3780:
URL: https://github.com/apache/incubator-nuttx/pull/3780


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org