You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/02 13:38:01 UTC

[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #2950: pcm_decode: add RAW format support

jerpelea commented on a change in pull request #2950:
URL: https://github.com/apache/incubator-nuttx/pull/2950#discussion_r585570251



##########
File path: audio/pcm_decode.c
##########
@@ -1087,6 +1090,7 @@ static int pcm_enqueuebuffer(FAR struct audio_lowerhalf_s *dev,
     {
       /* Parse and verify the candidate PCM WAV file header */
 
+#ifndef CONFIG_AUDIO_FORMAT_RAW
       if (pcm_parsewav(priv, &apb->samp[apb->curbyte]))

Review comment:
       @xiaoxiang781216 In case of  CONFIG_AUDIO_FORMAT_RAW pcm_parsewav is not defined and not used. Please merge the patch as is




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org