[GitHub] keith-turner commented on a change in pull request #356: ACCUMULO-4777 Removed the unused sequence generator.

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #356: ACCUMULO-4777 Removed the unused sequence generator.
URL: https://github.com/apache/accumulo/pull/356#discussion_r161266750
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
 ##########
 @@ -263,8 +263,11 @@
       "The maximum size for each write-ahead log. See comment for property tserver.memory.maps.max"),
   TSERV_WALOG_MAX_AGE("tserver.walog.max.age", "24h", PropertyType.TIMEDURATION, "The maximum age for each write-ahead log."),
   TSERV_WALOG_TOLERATED_CREATION_FAILURES("tserver.walog.tolerated.creation.failures", "50", PropertyType.COUNT,
-      "The maximum number of failures tolerated when creating a new WAL file within the period specified by tserver.walog.failures.period."
-          + " Exceeding this number of failures in the period causes the TabletServer to exit."),
+      "The maximum number of failures tolerated when creating a new WAL file."
+          + " Exceeding this number of failures consecutively trying to create a new WAL causes the TabletServer to exit."),
+  TSERV_WALOG_TOLERATED_WRITING_FAILURES("tserver.walog.tolerated.writing.failures", "1000", PropertyType.COUNT,
 
 Review comment:
   This would be a separate issue, but I think it would be more user friendly to make this a time based config.  For example retry for up to 30 min.  Also its nice to have the option to retry forever.  
   
   If DFS is grumpy for a bit, do we really want all tservers to exit?  This would also be a separate issue, but it would be nice if the behavior was different when all tservers are having problems vs a few tservers are having problems.  Maybe this is best handled outside of Accumulo, with tservers providing enough info for external system to make decisions about killing tservers. Basically the health check concept.  An external system can query all tservers for health info and make decsions about killing individual ones.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services