You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by NicoK <gi...@git.apache.org> on 2018/03/05 13:00:32 UTC

[GitHub] flink pull request #5637: [FLINK-8860][flip6] stop SlotManager spamming logs...

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/5637

    [FLINK-8860][flip6] stop SlotManager spamming logs for every TM heartbeat at log level 'info'

    ## What is the purpose of the change
    
    For every `TaskManager` heartbeat message, `SlotManager` was writing the message `Received slot report from instance...` into the logs at info level although this is clearly a debug information that is even already printed with a different of detail by the `ResourceManager`.
    
    ## Brief change log
    
    - change log level of a slot report to `debug`
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): **no**
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
      - The serializers: **no**
      - The runtime per-record code paths (performance sensitive): **no**
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **yes**
      - The S3 file system connector: **no**
    
    ## Documentation
    
      - Does this pull request introduce a new feature? **no**
      - If yes, how is the feature documented? **not applicable**


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-8860

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5637.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5637
    
----
commit aea1dc317d8f5280faadace3f872655a51f32b75
Author: Nico Kruber <ni...@...>
Date:   2018-03-05T12:55:04Z

    [FLINK-8860][flip6] stop SlotManager spamming logs for every TM heartbeat at log level 'info'

----


---

[GitHub] flink issue #5637: [FLINK-8860][flip6] stop SlotManager spamming logs for ev...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5637
  
    I would go for `TRACE` given how often we set the log level to `DEBUG`.


---

[GitHub] flink pull request #5637: [FLINK-8860][flip6] stop SlotManager spamming logs...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5637


---

[GitHub] flink issue #5637: [FLINK-8860][flip6] stop SlotManager spamming logs for ev...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5637
  
    merging.


---

[GitHub] flink issue #5637: [FLINK-8860][flip6] stop SlotManager spamming logs for ev...

Posted by NicoK <gi...@git.apache.org>.

Github user NicoK commented on the issue:

    https://github.com/apache/flink/pull/5637
  
    makes sense, since this is not indicating an error after all


---