You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/10/20 12:45:05 UTC
[GitHub] [fineract] ankita10r opened a new pull request #1917: FINERACT-1410 :Allow Payment types to map to all types of Ledgers
ankita10r opened a new pull request #1917:
URL: https://github.com/apache/fineract/pull/1917
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
<img width="1440" alt="Screenshot" src="https://user-images.githubusercontent.com/92036361/138095094-0512c850-13c4-4c8f-a49e-3c1681acda35.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1917: FINERACT-1410 :Allow Payment types to map to all types of Ledgers
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1917:
URL: https://github.com/apache/fineract/pull/1917#issuecomment-948850604
After merging this PR, Travis is failing on main.. Please, will you like help fix it? https://github.com/apache/fineract/runs/3962992775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1917: FINERACT-1410 :Allow Payment types to map to all types of Ledgers
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1917:
URL: https://github.com/apache/fineract/pull/1917#issuecomment-949299269
FYI - the failure was due to the SonarQube PR which is different from this - fixed now by a new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola closed pull request #1917: FINERACT-1410 :Allow Payment types to map to all types of Ledgers
Posted by GitBox <gi...@apache.org>.
ptuomola closed pull request #1917:
URL: https://github.com/apache/fineract/pull/1917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1917: FINERACT-1410 :Allow Payment types to map to all types of Ledgers
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1917:
URL: https://github.com/apache/fineract/pull/1917#issuecomment-948006055
Issue here: https://issues.apache.org/jira/browse/FINERACT-1410
Please @ankita10r , can you create your JIRA account here: https://issues.apache.org/jira so that we can begin assigning you to issues you fix.
CC @fynmanoj and @avikganguly01
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1917: FINERACT-1410 :Allow Payment types to map to all types of Ledgers
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1917:
URL: https://github.com/apache/fineract/pull/1917#issuecomment-947799015
Looks like TravisCI is working again. Let's wait to see if the build passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ankita10r commented on pull request #1917: FINERACT-1410 :Allow Payment types to map to all types of Ledgers
Posted by GitBox <gi...@apache.org>.
ankita10r commented on pull request #1917:
URL: https://github.com/apache/fineract/pull/1917#issuecomment-947673703
@ptuomola I actually committed twice in order to make travis run, it still didn't. Not sure why. Appreciate you looking into this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1917: FINERACT-1410 :Allow Payment types to map to all types of Ledgers
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1917:
URL: https://github.com/apache/fineract/pull/1917#issuecomment-947669372
Hello @ankita10r - very strange that Github is not running the Travis build for your pull request. Let me investigate why that's not happening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1917: FINERACT-1410 :Allow Payment types to map to all types of Ledgers
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1917:
URL: https://github.com/apache/fineract/pull/1917#issuecomment-947679763
@ankita10r I think the Apache account for Travis has hit some sort of limit - you can see an error "Owner apache user license exceeded" here: https://app.travis-ci.com/github/apache/fineract/requests
I'll see if I can get any help from the Apache infra team
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1917: FINERACT-1410 :Allow Payment types to map to all types of Ledgers
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1917:
URL: https://github.com/apache/fineract/pull/1917#issuecomment-947690640
I've raised a ticket with the Apache Infra team - let's see if they can help with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] avikganguly01 commented on pull request #1917: FINERACT-1410 :Allow Payment types to map to all types of Ledgers
Posted by GitBox <gi...@apache.org>.
avikganguly01 commented on pull request #1917:
URL: https://github.com/apache/fineract/pull/1917#issuecomment-948007586
Thank you @awasum for your guidance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] avikganguly01 merged pull request #1917: FINERACT-1410 :Allow Payment types to map to all types of Ledgers
Posted by GitBox <gi...@apache.org>.
avikganguly01 merged pull request #1917:
URL: https://github.com/apache/fineract/pull/1917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org