You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by keval bhatt <kb...@apache.org> on 2018/11/01 05:04:11 UTC

Re: Review Request 69221: ATLAS-2941 : Add schema rendering attribute for rdbms type


> On Oct. 31, 2018, 6:03 p.m., Sarath Subramanian wrote:
> > Did you get a chance to validate this in UI? Schema tabs with values is rendered for rdbms_table and rdbms_column?

Yes Sarath, I have tested the UI. Schema tab is coming up after this change


- keval


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69221/#review210231
-----------------------------------------------------------


On Oct. 31, 2018, 5:56 p.m., keval bhatt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69221/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2018, 5:56 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2941
>     https://issues.apache.org/jira/browse/ATLAS-2941
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Add patch for rdbms entity to render schema tab
> 
> 
> Diffs
> -----
> 
>   addons/models/2000-RDBMS/patches/001-rdbms_column_table_add_options.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69221/diff/1/
> 
> 
> Testing
> -------
> 
> Done one round of testing
> 
> 
> Thanks,
> 
> keval bhatt
> 
>