You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/09/30 10:00:59 UTC
[GitHub] [cloudstack] utchoang opened a new pull request, #6791: UI: Fixes UI style on Microsoft Edge browser
utchoang opened a new pull request, #6791:
URL: https://github.com/apache/cloudstack/pull/6791
### Description
This PR for fixes https://github.com/apache/cloudstack/issues/6787
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6791: UI: Fixes UI style on Microsoft Edge browser
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6791:
URL: https://github.com/apache/cloudstack/pull/6791#issuecomment-1263376759
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6791 (SL-JID-2447)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6791: UI: Fixes UI style on Microsoft Edge browser
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6791:
URL: https://github.com/apache/cloudstack/pull/6791#issuecomment-1263539520
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6791?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6791](https://codecov.io/gh/apache/cloudstack/pull/6791?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4251ce3) into [4.17](https://codecov.io/gh/apache/cloudstack/commit/432a03fb02870d3e3b6f72cd5d50c7846b25588b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (432a03f) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 4.17 #6791 +/- ##
============================================
- Coverage 10.33% 10.33% -0.01%
Complexity 6608 6608
============================================
Files 2451 2451
Lines 242339 242340 +1
Branches 37923 37924 +1
============================================
Hits 25054 25054
Misses 214200 214200
- Partials 3085 3086 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6791?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...n/java/com/cloud/template/TemplateManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6791/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3RlbXBsYXRlL1RlbXBsYXRlTWFuYWdlckltcGwuamF2YQ==) | `11.02% <0.00%> (-0.02%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on pull request #6791: UI: Fixes UI style on Microsoft Edge browser
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on PR #6791:
URL: https://github.com/apache/cloudstack/pull/6791#issuecomment-1265813798
I guess this is not the cause of the error seen. I have an env with the previous version of ACS, and I can not reproduce it.
furthermore, the proposed solution makes the listing stay above the menu, I think this is not the expected behavior (reproduced with the latest Firefox, Chromium, and Opera). The same behavior can be seen in the VPC view when you click to choose the page in the tabs `Public IP Address`, Ǹetwork ACL List`, `Private gateway`, `VPN connection`, `Virtual routers`, `Events`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6791: UI: Fixes UI style on Microsoft Edge browser
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6791:
URL: https://github.com/apache/cloudstack/pull/6791#issuecomment-1263369343
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] kohrar commented on pull request #6791: UI: Fixes UI style on Microsoft Edge browser
Posted by GitBox <gi...@apache.org>.
kohrar commented on PR #6791:
URL: https://github.com/apache/cloudstack/pull/6791#issuecomment-1265809177
@DaanHoogland That seemed to have done the trick! Thanks for this PR.
I do notice that there's a little discrepancy with the way the dropdown menu is being rendered. Sometimes it renders OK, but other times, the dropdown selection gets rendered on top of the dropdown element. I'm not sure what the correct terminology is, so forgive me. See the two screenshots below.
On a clean refresh or at (what seems to be) like at random times, it looks correct:
However, most of the time, just clicking on the dropdown causes the bottom to be chopped off and the selector gets rendered on top of the dropdown element:
Just clicking on / clicking away from the dropdown menu makes it render correctly maybe 20% of the time. I'm not sure why this is happening. This is not a huge issue since it's still functional, but thought I'd just bring this up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6791: UI: Fixes UI style on Microsoft Edge browser
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6791:
URL: https://github.com/apache/cloudstack/pull/6791#issuecomment-1265824173
> @DaanHoogland That seemed to have done the trick! Thanks for this PR.
>
> I do notice that there's a little discrepancy with the way the dropdown menu is being rendered. Sometimes it renders OK, but other times, the dropdown selection gets rendered on top of the dropdown element. I'm not sure what the correct terminology is, so forgive me. See the two screenshots below.
>
> On a clean refresh or at (what seems to be like) random times, it looks correct:
> 
>
> However, most of the time, just clicking on the dropdown causes the bottom to be chopped off and the selector gets rendered on top of the dropdown element:
> 
>
> Just clicking on / clicking away from the dropdown menu makes it render correctly maybe 20% of the time. I'm not sure why this is happening. This is not a huge issue since it's still functional, but thought I'd just bring this up.
@utchoang do you have an answer for @kohrar on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6791: UI: Fixes UI style on Microsoft Edge browser
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6791:
URL: https://github.com/apache/cloudstack/pull/6791#issuecomment-1264668961
@kohrar can you test this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6791: UI: Fixes UI style on Microsoft Edge browser
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6791:
URL: https://github.com/apache/cloudstack/pull/6791#issuecomment-1263368664
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6791: UI: Fixes UI style on Microsoft Edge browser
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6791:
URL: https://github.com/apache/cloudstack/pull/6791#issuecomment-1263430677
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6791)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6791&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6791&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6791&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6791&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6791&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6791&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6791&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6791&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6791&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6791&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6791&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6791&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6791&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6791&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org