[GitHub] [tinkerpop] divijvaidya commented on a change in pull request #1110: TINKERPOP-2211 Add API which allows per-request option for bytecode

[GitBox <gi...@apache.org>]

divijvaidya commented on a change in pull request #1110: TINKERPOP-2211 Add API which allows per-request option for bytecode
URL: https://github.com/apache/tinkerpop/pull/1110#discussion_r283043765
 
 

 ##########
 File path: gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Tokens.java
 ##########
 @@ -34,6 +34,7 @@ private Tokens() {}
     public static final String OPS_KEYS = "keys";
     public static final String OPS_CLOSE = "close";
 
+    public static final String ARGS_OVERRIDE_REQUEST_ID = "overrideRequestId";
 
 Review comment:
   Users don't know that the internal implementation uses a requestId. They should just be able to set a request ID when they want instead of "overriding" it.
   
   Could we rename this parameter from "overrideRequestId" to "requestId"?
   
   Also for completeness, please add this param to Client. submitAsync as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services