You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@hamilton.apache.org by "toyeshhm (via GitHub)" <gi...@apache.org> on 2026/09/09 17:27:31 UTC

[PR] docs: fix broken localhost URL in modular LLM stack example and spelling errors [hamilton]

toyeshhm opened a new pull request, #1706:
URL: https://github.com/apache/hamilton/pull/1706

   Documentation-only corrections; no code or behavioral change.
   
   ## Changes
   
   Two of these affect copy-pasteable instructions:
   
   - `examples/LLM_Workflows/modular_llm_stack/README.md`: the Weaviate invocation reads `--vector_db_config='{"url": "http://locahost:8080/"}'`. The Marqo and Qdrant lines beside it use `localhost`, so anyone copying the Weaviate line gets a resolution failure. Fixed to `localhost`.
   - `examples/kedro/hamilton-code/README.md`: refers to `noteboks/interactive.ipynb`, but the directory is `notebooks/`. Also `interactily` → `interactively` on the same line.
   
   The rest are plain spelling fixes across READMEs, `docs/`, and `writeups/`, e.g. `respository`, `initilization`, `quries`, `overriden`, `modeul`, `Additionnally`, `customizeable`, `inteface`, `commited`, `ressource`, `allways`, `eaisly`, `Excute`, `paralellism`, `parametter`, `depdendencies`, `pacakge`, `repetetive`; `informations` → `information`; `everytime` → `every time`; `wont` → `won't`; `doesn't makse sense` → `doesn't make sense`; and two doubled words (`go the the` → `go to the`, including in the PR template).
   
   Left alone on purpose: `rouge` (the ROUGE metric), `re-use`/`referencable` (style, not errors).
   
   ## How I tested this
   
   Re-read each changed line in context. `git diff --check` is clean. Only `.md` files are touched; 28 files, 34 lines.
   
   ## Notes
   
   `git diff --word-diff` shows the changes compactly.
   
   ## Checklist
   
   - [x] PR has an informative and human-readable title (this will be pulled into the release notes)
   - [x] Changes are limited to a single goal (no scope creep)
   - [x] Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
   - [ ] Any _change_ in functionality is tested (N/A, docs only)
   - [ ] New functions are documented (with a description, list of inputs, and expected output) (N/A)
   - [ ] Placeholder code is flagged / future TODOs are captured in comments (N/A)
   - [ ] Project documentation has been updated if adding/changing functionality. (N/A)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@hamilton.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] docs: fix broken localhost URL in modular LLM stack example and spelling errors [hamilton]

Posted by "skrawcz (via GitHub)" <gi...@apache.org>.
skrawcz merged PR #1706:
URL: https://github.com/apache/hamilton/pull/1706


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@hamilton.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org