You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/09/06 08:21:45 UTC

[GitHub] [iotdb] HTHou edited a comment on pull request #3910: [IOTDB-1088][WIP] Add API executeStatement

HTHou edited a comment on pull request #3910:
URL: https://github.com/apache/iotdb/pull/3910#issuecomment-913443669


   Hi, I checked the execute(String sql) method on IoTDB JDBC. It seems that it keeps a static ResultSet in this class. 
   I think we should do the same thing.
   
   https://github.com/apache/iotdb/blob/3333f3b2a6a5035b7f42a33dd23b3e841b0768b1/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBStatement.java#L251-L287
   
   I also checked the clickhouse and shardingsphere JDBC code and they all keep the ResultSet.
   
   IOTDB-1088 also states
   ```
   You must then use the methods * <code>getSessionDataSet</code> to retrieve the result.
   ```
   Therefore, I think we also need a method `getSessionDataSet`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org