You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@predictionio.apache.org by HyukjinKwon <gi...@git.apache.org> on 2016/08/09 04:22:01 UTC

[GitHub] incubator-predictionio pull request #271: [MINOR] Miscellaneous typos and co...

GitHub user HyukjinKwon opened a pull request:

    https://github.com/apache/incubator-predictionio/pull/271

    [MINOR] Miscellaneous typos and corrections in documentation

    This PR fixes miscellaneous typos and and corrects documentation across the documenation.
    
    This was initially proposed by @shanethehat, @linkthrow, @jamesward and @IAlwaysBeCoding and based on those PRs below.
    
    Closes apache/incubator-predictionio#220
    Closes apache/incubator-predictionio#228
    Closes apache/incubator-predictionio#234
    Closes apache/incubator-predictionio#240


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyukjinKwon/incubator-predictionio miscellaneous-typos

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-predictionio/pull/271.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #271
    
----
commit 582944ae605e5accfb118010aa13030eda1b52b6
Author: hyukjinkwon <gu...@gmail.com>
Date:   2016-08-09T03:58:23Z

    Change algoritm, algporithm and algoithm to algorithm

commit 6279a3cbed47d1c31fc76b7815b7a38ca57d5161
Author: hyukjinkwon <gu...@gmail.com>
Date:   2016-08-09T04:04:37Z

    Fix JSON data format

commit d9aa330f284e9cb1d5ae00cbf5caf9ef8e273e89
Author: hyukjinkwon <gu...@gmail.com>
Date:   2016-08-09T04:07:09Z

    Fix case case to case class

commit 69df1f67431edc8d332cf70bd0671f9f6fa136b4
Author: hyukjinkwon <gu...@gmail.com>
Date:   2016-08-09T04:15:53Z

    Fix markdown for installation instruction for PostgreSQL

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #271: [MINOR] Miscellaneous typos and correctio...

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/271
  
    BTW, I don't squash but committers will whether I do or not.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #271: [MINOR] Miscellaneous typos and correctio...

Posted by jamesward <gi...@git.apache.org>.

Github user jamesward commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/271
  
    Yeah, there are different types of merges.  If you squash then all the commits become one.  If you merge then the original commits are preserved.  Typically you wouldn't squash if the commits had multiple authors.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #271: [MINOR] Miscellaneous typos and correctio...

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/271
  
    I first thought this is okay (I have been doing this time to time in another project) but I will be careful of such cases. Thanks all again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #271: [MINOR] Miscellaneous typos and correctio...

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/271
  
    Yup, thanks all for great feedback. Let me clean this up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #271: [MINOR] Miscellaneous typos and correctio...

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/271
  
    I am not used to this project but I believe that's dependent on project's rules. At least, some projects in Apache do not allow that. Let me preserve the individual commit if this is allowed. Otherwise, let's just credit to you because the initial idea wasn't from me anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #271: [MINOR] Miscellaneous typos and correctio...

Posted by IAlwaysBeCoding <gi...@git.apache.org>.

Github user IAlwaysBeCoding commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/271
  
    Personally, am not to worry about what decision you guys take as long as the spelling mistakes are fixed. I will be happy if you merge them by cherry picking them pr squash the. 
    
    Cheers!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #271: [MINOR] Miscellaneous typos and correctio...

Posted by jamesward <gi...@git.apache.org>.

Github user jamesward commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/271
  
    You definitely could create a single PR that includes those individual commits.  Just add those remotes and cherry pick the commits.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #271: [MINOR] Miscellaneous typos and correctio...

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/271
  
    Hi @pferrel, I believe you are interested in documentation. Do you mind if I ask to review this please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #271: [MINOR] Miscellaneous typos and correctio...

Posted by jamesward <gi...@git.apache.org>.

Github user jamesward commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/271
  
    Why not use the original commits so that authorship is preserved?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #271: [MINOR] Miscellaneous typos and correctio...

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/271
  
    @jamesward I am happy to close this. I wanted to tie up the related PRs and fix the similar stuff across the codebase. 
    
    I don't mind which one is merged but maybe we should make sure that we fix the similar nits all across code base. I don't even mind if this one credits to one of those in related PRs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #271: [MINOR] Miscellaneous typos and correctio...

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/271
  
    @dszeto I just rebased and cherry-picked. Could you please take another look?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #271: [MINOR] Miscellaneous typos and correctio...

Posted by jamesward <gi...@git.apache.org>.

Github user jamesward commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/271
  
    That is only true if you squash the commits.  It really isn't a big deal for these kind of changes.  But typical form is to preserve authorship.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #271: [MINOR] Miscellaneous typos and correctio...

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/271
  
    No.. I hope I understood correctly. I mean yes I can preserve individual commits but regardless of how many commits exist in a PR, it is merged into a single one. For example, in https://github.com/apache/incubator-predictionio/pull/264 , I pushed several commits but it became a single PR https://github.com/apache/incubator-predictionio/commit/a92edd98314928428780ea03ca2ac221c9614a42. This would not be just merged by clicking the merge button. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #271: [MINOR] Miscellaneous typos and correctio...

Posted by dszeto <gi...@git.apache.org>.

Github user dszeto commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/271
  
    Great discussion here. We should update the contributor guideline regarding the choice of merging and squashing.
    
    I believe Apache does not enforce how pull requests should be handled, and it is up to committers to pick a style. Typically squashing is good for a single author branch so that it is easier (debatable :)) for other people to read what is changed for a particular ticket. For multi-author branches, I echo with @jamesward that it should not be squashed, as it is impossible to credit the squashed commit to multiple authors.
    
    @HyukjinKwon, if you wouldn't mind please cherry pick those commits into a branch and I will merge them instead of squashing. Apologies to everyone for the confusion and we will improve guidelines as we march forward to our first ASF release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---