[GitHub] [netbeans] oyarzun commented on pull request #2717: [NETBEANS-5004] Update macOS native launchers to call launcher shell script rather than nbexec

[GitBox <gi...@apache.org>]

oyarzun commented on pull request #2717:
URL: https://github.com/apache/netbeans/pull/2717#issuecomment-785133031


   > In the original PR you mentioned using Apple APIs to look up userdir and cache locations. Are the values in the script always correct? If not, another use for environment variables?
   
   The values in the script are correct, so there is no need to add it to the binary.
   
   ```shell
           # set default userdir and cachedir on Mac OS X
           DEFAULT_USERDIR_ROOT="${HOME}/Library/Application Support/${APPNAME}"
           DEFAULT_CACHEDIR_ROOT=${HOME}/Library/Caches/${APPNAME}
   ```
   
   > This looks a good change to me, and I like passing in the dock name as an environment variable. That actually covers one use I've had in platform apps for forking the launch script.
   
   What are your other changes to the launch script? Anything that should be added to the binary?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists