You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/08/19 11:52:46 UTC
[GitHub] [iceberg] xuzhiwen1255 opened a new pull request, #5586: Flink: Fixed a problem with parameter passing
xuzhiwen1255 opened a new pull request, #5586:
URL: https://github.com/apache/iceberg/pull/5586
**What has changed**
In RowDataTaskWriterFactory, the parameter in the OutputFileFactory should be taskid instead of attemptid. My PR fixes this problem.
```java
public void initialize(int taskId, int attemptId) {
this.outputFileFactory = OutputFileFactory.builderFor(table, taskId, attemptId)
.format(format)
.build();
}
public static Builder builderFor(Table table, int partitionId, long taskId) {
return new Builder(table, partitionId, taskId);
}
```
If we need to pass in taskid, I think we can rename it to avoid confusion of concepts.
@rdblue What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue closed pull request #5586: Flink: Fixed a problem with parameter passing
Posted by GitBox <gi...@apache.org>.
rdblue closed pull request #5586: Flink: Fixed a problem with parameter passing
URL: https://github.com/apache/iceberg/pull/5586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #5586: Flink: Fixed a problem with parameter passing
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #5586:
URL: https://github.com/apache/iceberg/pull/5586#issuecomment-1220816259
@xuzhiwen1255, I don't think this is correct. The task ID in Flink is the partition ID. I see how it may be confusing that there is a task ID in both cases, we want to use the stable one from Flink for partition ID and the unique one for task ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org