You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/28 06:44:50 UTC

[GitHub] [dolphinscheduler] 106umao commented on a diff in pull request #10642: Fix fix the hdfs invalid. #10641

106umao commented on code in PR #10642:
URL: https://github.com/apache/dolphinscheduler/pull/10642#discussion_r908095864


##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HadoopUtils.java:
##########
@@ -129,6 +129,11 @@ private void init() throws NullPointerException {
             }
 
             String defaultFS = configuration.get(Constants.FS_DEFAULT_FS);
+
+            if (defaultFS == null) {

Review Comment:
   > Can we optimize line 139 - 153? Some code is duplicate.
   
   👍 WIP. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org