You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "vidakovic (via GitHub)" <gi...@apache.org> on 2023/01/25 11:07:43 UTC
[GitHub] [fineract] vidakovic opened a new pull request, #2923: FINERACT-1857: Backport Flyway migrations to Liquibase for 1.8.x
vidakovic opened a new pull request, #2923:
URL: https://github.com/apache/fineract/pull/2923
Backport FINERACT-1846 for 1.8.x releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on a diff in pull request #2923: FINERACT-1857: Backport Flyway migrations to Liquibase for 1.8.x
Posted by "vidakovic (via GitHub)" <gi...@apache.org>.
vidakovic commented on code in PR #2923:
URL: https://github.com/apache/fineract/pull/2923#discussion_r1107328649
##########
fineract-provider/src/main/resources/db/changelog/tenant-store/upgrades/0000_upgrade_to_1.6.xml:
##########
@@ -0,0 +1,35 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.1.xsd">
+ <!-- V5__add_schema_connection_parameters.sql -->
+ <changeSet author="fineract" id="5">
Review Comment:
Note: this is a 1:1 backport of @josehernandezfintecheandomx 's implementation that is already merged in upstream develop. Maybe @josehernandezfintecheandomx can chime in here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on a diff in pull request #2923: FINERACT-1857: Backport Flyway migrations to Liquibase for 1.8.x
Posted by "vidakovic (via GitHub)" <gi...@apache.org>.
vidakovic commented on code in PR #2923:
URL: https://github.com/apache/fineract/pull/2923#discussion_r1107329432
##########
fineract-provider/src/main/resources/db/changelog/tenant/upgrades/0000_upgrade_to_1.5.xml:
##########
@@ -0,0 +1,100 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.1.xsd">
+ <!-- V362__reschedule_interest_to_lrs.sql -->
+ <changeSet author="fineract" id="362">
+ <addColumn tableName="m_loan_repayment_schedule">
+ <column name="reschedule_interest_portion" type="decimal(19,6)" defaultValueComputed="NULL" position="14" />
+ </addColumn>
+ </changeSet>
+ <!-- V363__mnote_indexing_for_performance.sql -->
+ <changeSet author="fineract" id="363">
+ <createIndex indexName="savings_account_transaction_id" tableName="m_note">
+ <column defaultValueComputed="NULL" name="savings_account_transaction_id"/>
+ </createIndex>
+ </changeSet>
+ <!-- V364__elastic_hook_template.sql -->
+ <changeSet author="fineract" id="364">
+ <insert tableName="m_hook_templates">
+ <column name="id" valueNumeric="3"/>
+ <column name="name" value="Elastic Search"/>
+ </insert>
+ <insert tableName="m_hook_schema">
+ <column name="id" valueNumeric="8"/>
+ <column name="hook_template_id" valueNumeric="3"/>
+ <column name="field_type" value="string"/>
+ <column name="field_name" value="Payload URL"/>
+ <column name="placeholder" value="http://<host>/<index name>/<type name>"/>
+ <column name="optional" valueBoolean="false"/>
+ </insert>
+ <insert tableName="m_hook_schema">
+ <column name="id" valueNumeric="9"/>
+ <column name="hook_template_id" valueNumeric="3"/>
+ <column name="field_type" value="string"/>
+ <column name="field_name" value="Content Type"/>
+ <column name="placeholder" value="json"/>
+ <column name="optional" valueBoolean="false"/>
+ </insert>
+ <insert tableName="m_hook_schema">
+ <column name="id" valueNumeric="10"/>
+ <column name="hook_template_id" valueNumeric="3"/>
+ <column name="field_type" value="string"/>
+ <column name="field_name" value="Index Name"/>
+ <column name="placeholder"/>
+ <column name="optional" valueBoolean="true"/>
+ </insert>
+ </changeSet>
+ <!-- V365__reportCategoryList-FINERACT-1306.sql -->
+ <changeSet author="fineract" id="365">
Review Comment:
Same here... maybe @josehernandezfintecheandomx can shed some light?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #2923: FINERACT-1857: Backport Flyway migrations to Liquibase for 1.8.x
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #2923:
URL: https://github.com/apache/fineract/pull/2923#discussion_r1107296720
##########
fineract-provider/src/main/resources/db/changelog/tenant/upgrades/0000_upgrade_to_1.5.xml:
##########
@@ -0,0 +1,100 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.1.xsd">
+ <!-- V362__reschedule_interest_to_lrs.sql -->
+ <changeSet author="fineract" id="362">
+ <addColumn tableName="m_loan_repayment_schedule">
+ <column name="reschedule_interest_portion" type="decimal(19,6)" defaultValueComputed="NULL" position="14" />
+ </addColumn>
+ </changeSet>
+ <!-- V363__mnote_indexing_for_performance.sql -->
+ <changeSet author="fineract" id="363">
+ <createIndex indexName="savings_account_transaction_id" tableName="m_note">
+ <column defaultValueComputed="NULL" name="savings_account_transaction_id"/>
+ </createIndex>
+ </changeSet>
+ <!-- V364__elastic_hook_template.sql -->
+ <changeSet author="fineract" id="364">
+ <insert tableName="m_hook_templates">
+ <column name="id" valueNumeric="3"/>
+ <column name="name" value="Elastic Search"/>
+ </insert>
+ <insert tableName="m_hook_schema">
+ <column name="id" valueNumeric="8"/>
+ <column name="hook_template_id" valueNumeric="3"/>
+ <column name="field_type" value="string"/>
+ <column name="field_name" value="Payload URL"/>
+ <column name="placeholder" value="http://<host>/<index name>/<type name>"/>
+ <column name="optional" valueBoolean="false"/>
+ </insert>
+ <insert tableName="m_hook_schema">
+ <column name="id" valueNumeric="9"/>
+ <column name="hook_template_id" valueNumeric="3"/>
+ <column name="field_type" value="string"/>
+ <column name="field_name" value="Content Type"/>
+ <column name="placeholder" value="json"/>
+ <column name="optional" valueBoolean="false"/>
+ </insert>
+ <insert tableName="m_hook_schema">
+ <column name="id" valueNumeric="10"/>
+ <column name="hook_template_id" valueNumeric="3"/>
+ <column name="field_type" value="string"/>
+ <column name="field_name" value="Index Name"/>
+ <column name="placeholder"/>
+ <column name="optional" valueBoolean="true"/>
+ </insert>
+ </changeSet>
+ <!-- V365__reportCategoryList-FINERACT-1306.sql -->
+ <changeSet author="fineract" id="365">
Review Comment:
V365__reportCategoryList-FINERACT-1306.sql looks different in flyway:
the two (stretchy report) tables are not missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #2923: FINERACT-1857: Backport Flyway migrations to Liquibase for 1.8.x
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #2923:
URL: https://github.com/apache/fineract/pull/2923#discussion_r1107289351
##########
fineract-provider/src/main/resources/db/changelog/tenant-store/upgrades/0000_upgrade_to_1.6.xml:
##########
@@ -0,0 +1,35 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.1.xsd">
+ <!-- V5__add_schema_connection_parameters.sql -->
+ <changeSet author="fineract" id="5">
Review Comment:
Flyway was setting the below to the default tenant. Is this okay to be left out?
```
UPDATE `tenant_server_connections`
SET `schema_connection_parameters`='${fineract.tenant.parameters}'
WHERE `id`=1;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #2923: FINERACT-1857: Backport Flyway migrations to Liquibase for 1.8.x
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #2923:
URL: https://github.com/apache/fineract/pull/2923#discussion_r1107296720
##########
fineract-provider/src/main/resources/db/changelog/tenant/upgrades/0000_upgrade_to_1.5.xml:
##########
@@ -0,0 +1,100 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.1.xsd">
+ <!-- V362__reschedule_interest_to_lrs.sql -->
+ <changeSet author="fineract" id="362">
+ <addColumn tableName="m_loan_repayment_schedule">
+ <column name="reschedule_interest_portion" type="decimal(19,6)" defaultValueComputed="NULL" position="14" />
+ </addColumn>
+ </changeSet>
+ <!-- V363__mnote_indexing_for_performance.sql -->
+ <changeSet author="fineract" id="363">
+ <createIndex indexName="savings_account_transaction_id" tableName="m_note">
+ <column defaultValueComputed="NULL" name="savings_account_transaction_id"/>
+ </createIndex>
+ </changeSet>
+ <!-- V364__elastic_hook_template.sql -->
+ <changeSet author="fineract" id="364">
+ <insert tableName="m_hook_templates">
+ <column name="id" valueNumeric="3"/>
+ <column name="name" value="Elastic Search"/>
+ </insert>
+ <insert tableName="m_hook_schema">
+ <column name="id" valueNumeric="8"/>
+ <column name="hook_template_id" valueNumeric="3"/>
+ <column name="field_type" value="string"/>
+ <column name="field_name" value="Payload URL"/>
+ <column name="placeholder" value="http://<host>/<index name>/<type name>"/>
+ <column name="optional" valueBoolean="false"/>
+ </insert>
+ <insert tableName="m_hook_schema">
+ <column name="id" valueNumeric="9"/>
+ <column name="hook_template_id" valueNumeric="3"/>
+ <column name="field_type" value="string"/>
+ <column name="field_name" value="Content Type"/>
+ <column name="placeholder" value="json"/>
+ <column name="optional" valueBoolean="false"/>
+ </insert>
+ <insert tableName="m_hook_schema">
+ <column name="id" valueNumeric="10"/>
+ <column name="hook_template_id" valueNumeric="3"/>
+ <column name="field_type" value="string"/>
+ <column name="field_name" value="Index Name"/>
+ <column name="placeholder"/>
+ <column name="optional" valueBoolean="true"/>
+ </insert>
+ </changeSet>
+ <!-- V365__reportCategoryList-FINERACT-1306.sql -->
+ <changeSet author="fineract" id="365">
Review Comment:
V365__reportCategoryList-FINERACT-1306.sql looks different in flyway:
the two tables are not missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic merged pull request #2923: FINERACT-1857: Backport Flyway migrations to Liquibase for 1.8.x
Posted by "vidakovic (via GitHub)" <gi...@apache.org>.
vidakovic merged PR #2923:
URL: https://github.com/apache/fineract/pull/2923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org