You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by bi...@apache.org on 2017/01/19 10:19:12 UTC

kylin git commit: minor, refine Singleton clear in AbstractKylinTestCase

Repository: kylin
Updated Branches:
  refs/heads/refine-test-message [created] c46ec6ab2


minor, refine Singleton clear in AbstractKylinTestCase


Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/c46ec6ab
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/c46ec6ab
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/c46ec6ab

Branch: refs/heads/refine-test-message
Commit: c46ec6ab2c9ecc0a3a874ace0c08e66cbbd81298
Parents: 61833d9
Author: Billy Liu <bi...@apache.org>
Authored: Thu Jan 19 18:18:52 2017 +0800
Committer: Billy Liu <bi...@apache.org>
Committed: Thu Jan 19 18:18:52 2017 +0800

----------------------------------------------------------------------
 .../org/apache/kylin/common/util/AbstractKylinTestCase.java    | 5 +++++
 .../java/org/apache/kylin/dict/lookup/SnapshotManager.java     | 6 ++++++
 .../src/main/java/org/apache/kylin/job/dao/ExecutableDao.java  | 6 ++++++
 .../java/org/apache/kylin/metadata/cachesync/Broadcaster.java  | 2 +-
 4 files changed, 18 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kylin/blob/c46ec6ab/core-common/src/test/java/org/apache/kylin/common/util/AbstractKylinTestCase.java
----------------------------------------------------------------------
diff --git a/core-common/src/test/java/org/apache/kylin/common/util/AbstractKylinTestCase.java b/core-common/src/test/java/org/apache/kylin/common/util/AbstractKylinTestCase.java
index 2154c32..e835d48 100644
--- a/core-common/src/test/java/org/apache/kylin/common/util/AbstractKylinTestCase.java
+++ b/core-common/src/test/java/org/apache/kylin/common/util/AbstractKylinTestCase.java
@@ -31,12 +31,17 @@ public abstract class AbstractKylinTestCase {
     public static final String[] SERVICES_WITH_CACHE = { //
             "org.apache.kylin.cube.CubeManager", //
             "org.apache.kylin.cube.CubeDescManager", //
+            "org.apache.kylin.dict.lookup.SnapshotManager", //
+            "org.apache.kylin.dict.DictionaryManager", //
             "org.apache.kylin.storage.hybrid.HybridManager", //
             "org.apache.kylin.metadata.realization.RealizationRegistry", //
             "org.apache.kylin.metadata.project.ProjectManager", //
             "org.apache.kylin.metadata.MetadataManager", //
+            "org.apache.kylin.metadata.cachesync.Broadcaster", //
+            "org.apache.kylin.metadata.badquery.BadQueryHistoryManager", //
             "org.apache.kylin.job.impl.threadpool.DistributedScheduler", //
             "org.apache.kylin.job.manager.ExecutableManager", //
+            "org.apache.kylin.job.dao.ExecutableDao" //
     };
 
     public abstract void createTestMetadata() throws Exception;

http://git-wip-us.apache.org/repos/asf/kylin/blob/c46ec6ab/core-dictionary/src/main/java/org/apache/kylin/dict/lookup/SnapshotManager.java
----------------------------------------------------------------------
diff --git a/core-dictionary/src/main/java/org/apache/kylin/dict/lookup/SnapshotManager.java b/core-dictionary/src/main/java/org/apache/kylin/dict/lookup/SnapshotManager.java
index 085158a..b45d017 100644
--- a/core-dictionary/src/main/java/org/apache/kylin/dict/lookup/SnapshotManager.java
+++ b/core-dictionary/src/main/java/org/apache/kylin/dict/lookup/SnapshotManager.java
@@ -66,6 +66,12 @@ public class SnapshotManager {
         return r;
     }
 
+    public static void clearCache() {
+        synchronized (SERVICE_CACHE) {
+            SERVICE_CACHE.clear();
+        }
+    }
+
     // ============================================================================
 
     private KylinConfig config;

http://git-wip-us.apache.org/repos/asf/kylin/blob/c46ec6ab/core-job/src/main/java/org/apache/kylin/job/dao/ExecutableDao.java
----------------------------------------------------------------------
diff --git a/core-job/src/main/java/org/apache/kylin/job/dao/ExecutableDao.java b/core-job/src/main/java/org/apache/kylin/job/dao/ExecutableDao.java
index 5cae5ac..96505e6 100644
--- a/core-job/src/main/java/org/apache/kylin/job/dao/ExecutableDao.java
+++ b/core-job/src/main/java/org/apache/kylin/job/dao/ExecutableDao.java
@@ -64,6 +64,12 @@ public class ExecutableDao {
         return r;
     }
 
+    public static void clearCache() {
+        synchronized (CACHE) {
+            CACHE.clear();
+        }
+    }
+
     private ExecutableDao(KylinConfig config) {
         logger.info("Using metadata url: " + config);
         this.store = MetadataManager.getInstance(config).getStore();

http://git-wip-us.apache.org/repos/asf/kylin/blob/c46ec6ab/core-metadata/src/main/java/org/apache/kylin/metadata/cachesync/Broadcaster.java
----------------------------------------------------------------------
diff --git a/core-metadata/src/main/java/org/apache/kylin/metadata/cachesync/Broadcaster.java b/core-metadata/src/main/java/org/apache/kylin/metadata/cachesync/Broadcaster.java
index d00c490..17b644d 100644
--- a/core-metadata/src/main/java/org/apache/kylin/metadata/cachesync/Broadcaster.java
+++ b/core-metadata/src/main/java/org/apache/kylin/metadata/cachesync/Broadcaster.java
@@ -83,7 +83,7 @@ public class Broadcaster {
     }
 
     // call Broadcaster.getInstance().notifyClearAll() to clear cache
-    static void clearCache() {
+    public static void clearCache() {
         synchronized (CACHE) {
             CACHE.clear();
         }