You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Aleksandr Kovalenko <ak...@hortonworks.com> on 2014/05/15 13:05:15 UTC

Review Request 21482: Add unit tests for service models

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21482/
-----------------------------------------------------------

Review request for Ambari and Oleg Nechiporenko.


Bugs: AMBARI-5772
    https://issues.apache.org/jira/browse/AMBARI-5772


Repository: ambari


Description
-------

Cover all models/service/*.js files with unit tests.


Diffs
-----

  ambari-web/app/assets/test/tests.js 2636f75 
  ambari-web/test/init_model_test.js bb36034 
  ambari-web/test/models/service/flume_test.js PRE-CREATION 
  ambari-web/test/models/service/hbase_test.js PRE-CREATION 
  ambari-web/test/models/service/hdfs_test.js PRE-CREATION 
  ambari-web/test/models/service/mapreduce2_test.js PRE-CREATION 
  ambari-web/test/models/service/mapreduce_test.js PRE-CREATION 
  ambari-web/test/models/service/yarn_test.js PRE-CREATION 

Diff: https://reviews.apache.org/r/21482/diff/


Testing
-------

4654 tests complete.


Thanks,

Aleksandr Kovalenko


Re: Review Request 21482: Add unit tests for service models

Posted by Oleg Nechiporenko <on...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21482/#review43099
-----------------------------------------------------------

Ship it!


Ship It!

- Oleg Nechiporenko


On May 15, 2014, 11:05 a.m., Aleksandr Kovalenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21482/
> -----------------------------------------------------------
> 
> (Updated May 15, 2014, 11:05 a.m.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-5772
>     https://issues.apache.org/jira/browse/AMBARI-5772
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Cover all models/service/*.js files with unit tests.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/test/tests.js 2636f75 
>   ambari-web/test/init_model_test.js bb36034 
>   ambari-web/test/models/service/flume_test.js PRE-CREATION 
>   ambari-web/test/models/service/hbase_test.js PRE-CREATION 
>   ambari-web/test/models/service/hdfs_test.js PRE-CREATION 
>   ambari-web/test/models/service/mapreduce2_test.js PRE-CREATION 
>   ambari-web/test/models/service/mapreduce_test.js PRE-CREATION 
>   ambari-web/test/models/service/yarn_test.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21482/diff/
> 
> 
> Testing
> -------
> 
> 4654 tests complete.
> 
> 
> Thanks,
> 
> Aleksandr Kovalenko
> 
>