You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/08/24 21:03:52 UTC
Re: Review Request 37585: Maintenance primitives: Add a user doc.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/
-----------------------------------------------------------
(Updated Aug. 24, 2015, 12:03 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
Bugs: MESOS-2083
https://issues.apache.org/jira/browse/MESOS-2083
Repository: mesos
Description (updated)
-------
Heavily based on the design doc (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
Includes a diagram of the maintenance mode transitions.
This documents the current working prototype (MVP), which starts here:
https://reviews.apache.org/r/36321/
One TODO remaining: Update with the release version that maintenance primitives will be released in.
Diffs
-----
docs/images/maintenance-primitives-modes.png PRE-CREATION
docs/maintenance.md PRE-CREATION
Diff: https://reviews.apache.org/r/37585/diff/
Testing
-------
Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
Checked for markdown correctness.
Thanks,
Joseph Wu
Re: Review Request 37585: Maintenance primitives: Add a user doc.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Sept. 12, 2015, 6:59 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, lines 68-72
> > <https://reviews.apache.org/r/37585/diff/9/?file=1061438#file1061438line68>
> >
> > Did not we describe this already?
True. The intention was to reword the documentation in the protobufs. But I think it should be ok remove this section.
> On Sept. 12, 2015, 6:59 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, line 58
> > <https://reviews.apache.org/r/37585/diff/9/?file=1061438#file1061438line58>
> >
> > Why is this a Note?
I wanted it to be emphasized (that modes are all manually transitioned). Although, given how short this section is, I guess it isn't necessary.
> On Sept. 12, 2015, 6:59 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, line 77
> > <https://reviews.apache.org/r/37585/diff/9/?file=1061438#file1061438line77>
> >
> > Here we use will, and bellow we use could. Please go over the entire doc and make sure that the use of tense is consistent. Please check other Mesos docs and see which tense do they normally use.
Looks like we should use present tense.
There are a few places where I still use future tense. This is primarily to describe things like:
The operator posts something to the endpoint.
Master will do something in response.
> On Sept. 12, 2015, 6:59 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, line 93
> > <https://reviews.apache.org/r/37585/diff/9/?file=1061438#file1061438line93>
> >
> > Is it nanonsecods since UNIX epoch? Can we just use seconds in the eaxmaple?
Yes.
I wanted the example to be correct/runnable. So the extra 9 zeroes are necessary. (I added a more reasonable timestamp, Oct 05, 2015.)
> On Sept. 12, 2015, 6:59 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, line 137
> > <https://reviews.apache.org/r/37585/diff/9/?file=1061438#file1061438line137>
> >
> > what about duration? Can't we just leave it empty?
Oops, this is no longer accurate.
> On Sept. 12, 2015, 6:59 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, line 138
> > <https://reviews.apache.org/r/37585/diff/9/?file=1061438#file1061438line138>
> >
> > Can't we have deactivated machines outside a maintenance schedule?
This is currently not supported. (Because it's one of the two maintenance mode transitions we didn't implement.)
> On Sept. 12, 2015, 6:59 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, line 228
> > <https://reviews.apache.org/r/37585/diff/9/?file=1061438#file1061438line228>
> >
> > s/even if/even when/?
I think `even if` flows better here.
> On Sept. 12, 2015, 6:59 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, line 242
> > <https://reviews.apache.org/r/37585/diff/9/?file=1061438#file1061438line242>
> >
> > can we make sure that `above` is a link here?
Unfortunately, the docs on the website aren't generated with `#`-linkable blocks.
> On Sept. 12, 2015, 6:59 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, line 128
> > <https://reviews.apache.org/r/37585/diff/9/?file=1061438#file1061438line128>
> >
> > s/need to/MUST/. In general I would susggest to go over the docment and make sure we consistently use MUST,SHOULD, MAY (a la https://www.ietf.org/rfc/rfc2119.txt)
Done.
Note about "can" and "may". I used "can" to express that something "is possible". I used "may" to express something "is allowed".
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review98703
-----------------------------------------------------------
On Sept. 14, 2015, 2:32 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 2:32 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
>
>
> Bugs: MESOS-2083
> https://issues.apache.org/jira/browse/MESOS-2083
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Heavily based on the design doc (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
>
> Includes a diagram of the maintenance mode transitions.
>
>
> Diffs
> -----
>
> docs/images/maintenance-primitives-modes.png PRE-CREATION
> docs/maintenance.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37585/diff/
>
>
> Testing
> -------
>
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
>
>
> File Attachments
> ----------------
>
> Same as the image in the binary diff. (Uploaded for reviewer convenience.)
> https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 37585: Maintenance primitives: Add a user doc.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review98703
-----------------------------------------------------------
docs/maintenance.md (line 9)
<https://reviews.apache.org/r/37585/#comment155261>
s/maintenance is task affecting/can affect running tasks/
docs/maintenance.md (line 15)
<https://reviews.apache.org/r/37585/#comment155262>
s/first sentence/Frameworks require visibility into the actions that disrupt cluster operation in order to be able to meet Service Level Agreemenets and/or to ensure uninterrupted service operation for the end users.
docs/maintenance.md (line 24)
<https://reviews.apache.org/r/37585/#comment155263>
s/adds/add/?
docs/maintenance.md (line 25)
<https://reviews.apache.org/r/37585/#comment155264>
s/These concepts are defined as the following:/Those concepts are:
/
docs/maintenance.md (line 27)
<https://reviews.apache.org/r/37585/#comment155266>
s/an agent/a machine/
docs/maintenance.md (line 29)
<https://reviews.apache.org/r/37585/#comment155267>
A set of machines with an associated period of time during which the maintenance is planned on those machines.
docs/maintenance.md (line 31)
<https://reviews.apache.org/r/37585/#comment155268>
s/windows./windows each consisting of a unique set of machines.
docs/maintenance.md (line 32)
<https://reviews.apache.org/r/37585/#comment155271>
s/A period/A tentative period/
s/an associated agent/an associated machine/
s/no guarantees can be made/no assumptions should be mage about the availability of Machine (or resources) past the unavailiability period./
docs/maintenance.md (line 35)
<https://reviews.apache.org/r/37585/#comment155350>
Please mention that framework running on draining machines should receieve inverse offers, and that offers sent with resources from draining machines have unavailability set.
docs/maintenance.md (line 40)
<https://reviews.apache.org/r/37585/#comment155351>
I would mention here the similiraty with normal offers.
docs/maintenance.md (line 53)
<https://reviews.apache.org/r/37585/#comment155352>
Maintenance primitives were introduced in Mesos 0.25.0. With introduction of the primitive the following machine maintenance modes have also been added:
docs/maintenance.md (line 58)
<https://reviews.apache.org/r/37585/#comment155353>
Why is this a Note?
docs/maintenance.md (line 65)
<https://reviews.apache.org/r/37585/#comment155354>
s/For the operator..../To transition a machine into Draining mode an operator constructs a maintenance schedule and posts it to the Mesos master./
docs/maintenance.md (lines 68 - 72)
<https://reviews.apache.org/r/37585/#comment155356>
Did not we describe this already?
docs/maintenance.md (line 77)
<https://reviews.apache.org/r/37585/#comment155357>
Here we use will, and bellow we use could. Please go over the entire doc and make sure that the use of tense is consistent. Please check other Mesos docs and see which tense do they normally use.
docs/maintenance.md (line 93)
<https://reviews.apache.org/r/37585/#comment155355>
Is it nanonsecods since UNIX epoch? Can we just use seconds in the eaxmaple?
docs/maintenance.md (line 118)
<https://reviews.apache.org/r/37585/#comment155358>
s/currently part of the cluster/registered with Mesos master/.
docs/maintenance.md (line 120)
<https://reviews.apache.org/r/37585/#comment155359>
s/potentially//
docs/maintenance.md (lines 120 - 122)
<https://reviews.apache.org/r/37585/#comment155360>
We first speak about schedule, and then all of a sudden jump to deactivated machines. I would suggest to move the part about deactivated machines to a section below.
docs/maintenance.md (line 124)
<https://reviews.apache.org/r/37585/#comment155361>
Were all the prior notes not important? ;)
docs/maintenance.md (line 128)
<https://reviews.apache.org/r/37585/#comment155362>
s/need to/MUST/. In general I would susggest to go over the docment and make sure we consistently use MUST,SHOULD, MAY (a la https://www.ietf.org/rfc/rfc2119.txt)
docs/maintenance.md (line 137)
<https://reviews.apache.org/r/37585/#comment155363>
what about duration? Can't we just leave it empty?
docs/maintenance.md (line 138)
<https://reviews.apache.org/r/37585/#comment155364>
Can't we have deactivated machines outside a maintenance schedule?
docs/maintenance.md (line 142)
<https://reviews.apache.org/r/37585/#comment155365>
s/a number of things/the following things/
docs/maintenance.md (lines 174 - 176)
<https://reviews.apache.org/r/37585/#comment155366>
A framework can use a filter to control when it wants to be contacted again with the inverse offer. This is useful since....
docs/maintenance.md (lines 180 - 182)
<https://reviews.apache.org/r/37585/#comment155367>
s/.*/Accepting an inverse offer is perceived as a best-effort promise by the framework to free all the resources contained in the inverse offer by the start of maintenance time.
docs/maintenance.md (line 194)
<https://reviews.apache.org/r/37585/#comment155368>
s/endpoints/endpoint/.
docs/maintenance.md (lines 213 - 218)
<https://reviews.apache.org/r/37585/#comment155369>
incosistent use of may/must + present tense.
docs/maintenance.md (line 228)
<https://reviews.apache.org/r/37585/#comment155370>
s/even if/even when/?
docs/maintenance.md (line 242)
<https://reviews.apache.org/r/37585/#comment155371>
can we make sure that `above` is a link here?
docs/maintenance.md (line 243)
<https://reviews.apache.org/r/37585/#comment155372>
would?
- Artem Harutyunyan
On Sept. 1, 2015, 10:42 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 10:42 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
>
>
> Bugs: MESOS-2083
> https://issues.apache.org/jira/browse/MESOS-2083
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Heavily based on the design doc (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
>
> Includes a diagram of the maintenance mode transitions.
>
> This documents the current working prototype (MVP), which starts here:
> https://reviews.apache.org/r/36321/
>
> One TODO remaining: Update with the release version that maintenance primitives will be released in.
>
>
> Diffs
> -----
>
> docs/images/maintenance-primitives-modes.png PRE-CREATION
> docs/maintenance.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37585/diff/
>
>
> Testing
> -------
>
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
>
>
> File Attachments
> ----------------
>
> Same as the image in the binary diff. (Uploaded for reviewer convenience.)
> https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 37585: Maintenance primitives: Add a user doc.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review99656
-----------------------------------------------------------
Bad patch!
Reviews applied: [37585]
Failed command: ./support/apply-review.sh -n -r 37585
Error:
2015-09-19 06:46:30 URL:https://reviews.apache.org/r/37585/diff/raw/ [13712/13712] -> "37585.patch" [1]
error: missing binary patch data for 'docs/images/maintenance-primitives-modes.png'
error: binary patch does not apply to 'docs/images/maintenance-primitives-modes.png'
error: docs/images/maintenance-primitives-modes.png: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Sept. 19, 2015, 1:27 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2015, 1:27 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
>
>
> Bugs: MESOS-2083
> https://issues.apache.org/jira/browse/MESOS-2083
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Heavily based on the design doc (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
>
> Includes a diagram of the maintenance mode transitions.
>
>
> Diffs
> -----
>
> docs/images/maintenance-primitives-modes.png PRE-CREATION
> docs/maintenance.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37585/diff/
>
>
> Testing
> -------
>
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
>
>
> File Attachments
> ----------------
>
> Same as the image in the binary diff. (Uploaded for reviewer convenience.)
> https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 37585: Maintenance primitives: Add a user doc.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review99711
-----------------------------------------------------------
Ship it!
fixed inline.
docs/maintenance.md (lines 139 - 140)
<https://reviews.apache.org/r/37585/#comment156695>
It wasn't clear at first what you meant by "this is not allowed", as you are stating a rule above.
- Joris Van Remoortere
On Sept. 19, 2015, 1:27 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2015, 1:27 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
>
>
> Bugs: MESOS-2083
> https://issues.apache.org/jira/browse/MESOS-2083
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Heavily based on the design doc (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
>
> Includes a diagram of the maintenance mode transitions.
>
>
> Diffs
> -----
>
> docs/images/maintenance-primitives-modes.png PRE-CREATION
> docs/maintenance.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37585/diff/
>
>
> Testing
> -------
>
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
>
>
> File Attachments
> ----------------
>
> Same as the image in the binary diff. (Uploaded for reviewer convenience.)
> https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 37585: Maintenance primitives: Add a user doc.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/
-----------------------------------------------------------
(Updated Sept. 18, 2015, 6:27 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
Changes
-------
Addressed most of Artem's comments.
Bugs: MESOS-2083
https://issues.apache.org/jira/browse/MESOS-2083
Repository: mesos
Description
-------
Heavily based on the design doc (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
Includes a diagram of the maintenance mode transitions.
Diffs (updated)
-----
docs/images/maintenance-primitives-modes.png PRE-CREATION
docs/maintenance.md PRE-CREATION
Diff: https://reviews.apache.org/r/37585/diff/
Testing
-------
Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
Checked for markdown correctness.
File Attachments
----------------
Same as the image in the binary diff. (Uploaded for reviewer convenience.)
https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png
Thanks,
Joseph Wu
Re: Review Request 37585: Maintenance primitives: Add a user doc.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, line 27
> > <https://reviews.apache.org/r/37585/diff/11/?file=1076950#file1076950line27>
> >
> > Did the notion of an operator not exist before Maintenance Primitives were introduced? I would rephrase the sentence above to say that we're definining terms for the puropse of this doc.
Moved to the top of the section.
> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, lines 91-92
> > <https://reviews.apache.org/r/37585/diff/11/?file=1076950#file1076950line91>
> >
> > Can they also specify seconds? If not, we should definitely add a JIRA for that (as a syntactic sugar for the interface). Please mention somewhere that start is the nanoseconds since epoch.
Added a note.
However, any seconds-based usage might be kind of weird (we removed it before because it's simpler this way).
> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, line 134
> > <https://reviews.apache.org/r/37585/diff/11/?file=1076950#file1076950line134>
> >
> > What does this mean? What if they aren't?
Added extra sentences.
> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, line 135
> > <https://reviews.apache.org/r/37585/diff/11/?file=1076950#file1076950line135>
> >
> > Please explain a recommended workflow for updating maintenance schedule, and canceling it.
Added two sentences at the end of this section.
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review99635
-----------------------------------------------------------
On Sept. 18, 2015, 6:27 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 6:27 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
>
>
> Bugs: MESOS-2083
> https://issues.apache.org/jira/browse/MESOS-2083
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Heavily based on the design doc (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
>
> Includes a diagram of the maintenance mode transitions.
>
>
> Diffs
> -----
>
> docs/images/maintenance-primitives-modes.png PRE-CREATION
> docs/maintenance.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37585/diff/
>
>
> Testing
> -------
>
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
>
>
> File Attachments
> ----------------
>
> Same as the image in the binary diff. (Uploaded for reviewer convenience.)
> https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 37585: Maintenance primitives: Add a user doc.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, lines 72-73
> > <https://reviews.apache.org/r/37585/diff/11/?file=1076950#file1076950line72>
> >
> > Please add anchors to links so that the relevant parts of the .proto file in each case are highlighted.
I'll need to reference a specific commit then. (See if you prefer it this way).
> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, line 120
> > <https://reviews.apache.org/r/37585/diff/11/?file=1076950#file1076950line120>
> >
> > What does this mean for the person reading this? Should they supply extra options through the agent command line? Should they make sure that their /etc/hosts is sane? This is currently not actionable, but it has to be.
I'll add the sentence:
If there is any ambiguity in a machine's configuration, the operator should use the `--hostname` and `--ip` options when starting agents.
> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, line 127
> > <https://reviews.apache.org/r/37585/diff/11/?file=1076950#file1076950line127>
> >
> > What if one or several of the checks fail?
Added:
If any of these properties are not met, the maintenance schedule is rejected with a corresponding error message and the master's state does not change.
> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, line 133
> > <https://reviews.apache.org/r/37585/diff/11/?file=1076950#file1076950line133>
> >
> > Isn't this one obvious?
I suppose so. Removed.
> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, lines 144-145
> > <https://reviews.apache.org/r/37585/diff/11/?file=1076950#file1076950line144>
> >
> > Does this potentially mean a mass task restart across the nodes that are undergoing maintenance?
I'm not sure where you got this?
> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, line 190
> > <https://reviews.apache.org/r/37585/diff/11/?file=1076950#file1076950line190>
> >
> > a link to .proto would be helpful here too.
A proto doesn't exist for this anymore :)
I can point to MachineID though.
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review99635
-----------------------------------------------------------
On Sept. 18, 2015, 6:27 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 6:27 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
>
>
> Bugs: MESOS-2083
> https://issues.apache.org/jira/browse/MESOS-2083
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Heavily based on the design doc (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
>
> Includes a diagram of the maintenance mode transitions.
>
>
> Diffs
> -----
>
> docs/images/maintenance-primitives-modes.png PRE-CREATION
> docs/maintenance.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37585/diff/
>
>
> Testing
> -------
>
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
>
>
> File Attachments
> ----------------
>
> Same as the image in the binary diff. (Uploaded for reviewer convenience.)
> https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 37585: Maintenance primitives: Add a user doc.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review99635
-----------------------------------------------------------
docs/maintenance.md (line 25)
<https://reviews.apache.org/r/37585/#comment156575>
s/adds/add/.
docs/maintenance.md (line 27)
<https://reviews.apache.org/r/37585/#comment156576>
Did the notion of an operator not exist before Maintenance Primitives were introduced? I would rephrase the sentence above to say that we're definining terms for the puropse of this doc.
docs/maintenance.md (line 35)
<https://reviews.apache.org/r/37585/#comment156577>
s/in/during/
s/may not be/may become/
docs/maintenance.md (line 36)
<https://reviews.apache.org/r/37585/#comment156579>
s/about the/about the availability of the/
docs/maintenance.md (line 40)
<https://reviews.apache.org/r/37585/#comment156580>
s/will have unavailability info attached/will contain unavailability information/
docs/maintenance.md (lines 72 - 73)
<https://reviews.apache.org/r/37585/#comment156581>
Please add anchors to links so that the relevant parts of the .proto file in each case are highlighted.
docs/maintenance.md (line 75)
<https://reviews.apache.org/r/37585/#comment156582>
s/the schedule is/the schedule must be/
docs/maintenance.md (lines 91 - 92)
<https://reviews.apache.org/r/37585/#comment156583>
Can they also specify seconds? If not, we should definitely add a JIRA for that (as a syntactic sugar for the interface). Please mention somewhere that start is the nanoseconds since epoch.
docs/maintenance.md (line 107)
<https://reviews.apache.org/r/37585/#comment156584>
s/this schedule/the schedule/
docs/maintenance.md (line 118)
<https://reviews.apache.org/r/37585/#comment156585>
s/if, say, a faulty machine launches agents on boot./to, say, prevent a faulty machine from launching an agent on boot./
docs/maintenance.md (line 120)
<https://reviews.apache.org/r/37585/#comment156586>
What does this mean for the person reading this? Should they supply extra options through the agent command line? Should they make sure that their /etc/hosts is sane? This is currently not actionable, but it has to be.
docs/maintenance.md (line 127)
<https://reviews.apache.org/r/37585/#comment156588>
What if one or several of the checks fail?
docs/maintenance.md (line 133)
<https://reviews.apache.org/r/37585/#comment156589>
Isn't this one obvious?
docs/maintenance.md (line 134)
<https://reviews.apache.org/r/37585/#comment156590>
What does this mean? What if they aren't?
docs/maintenance.md (line 135)
<https://reviews.apache.org/r/37585/#comment156591>
Please explain a recommended workflow for updating maintenance schedule, and canceling it.
docs/maintenance.md (lines 144 - 145)
<https://reviews.apache.org/r/37585/#comment156592>
Does this potentially mean a mass task restart across the nodes that are undergoing maintenance?
docs/maintenance.md (line 190)
<https://reviews.apache.org/r/37585/#comment156593>
a link to .proto would be helpful here too.
docs/maintenance.md (line 203)
<https://reviews.apache.org/r/37585/#comment156595>
Again, not clear what happens if one of these conditions fails.
docs/maintenance.md (line 224)
<https://reviews.apache.org/r/37585/#comment156597>
s/maintenance starts/maintenance is triggered by the operator/.
docs/maintenance.md (line 235)
<https://reviews.apache.org/r/37585/#comment156598>
Link to .proto, please?
docs/maintenance.md (line 249)
<https://reviews.apache.org/r/37585/#comment156599>
s/guess/a best effort guess/
- Artem Harutyunyan
On Sept. 18, 2015, 12:51 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 12:51 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
>
>
> Bugs: MESOS-2083
> https://issues.apache.org/jira/browse/MESOS-2083
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Heavily based on the design doc (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
>
> Includes a diagram of the maintenance mode transitions.
>
>
> Diffs
> -----
>
> docs/images/maintenance-primitives-modes.png PRE-CREATION
> docs/maintenance.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37585/diff/
>
>
> Testing
> -------
>
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
>
>
> File Attachments
> ----------------
>
> Same as the image in the binary diff. (Uploaded for reviewer convenience.)
> https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 37585: Maintenance primitives: Add a user doc.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review99596
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37585]
All tests passed.
- Mesos ReviewBot
On Sept. 18, 2015, 7:51 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 7:51 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
>
>
> Bugs: MESOS-2083
> https://issues.apache.org/jira/browse/MESOS-2083
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Heavily based on the design doc (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
>
> Includes a diagram of the maintenance mode transitions.
>
>
> Diffs
> -----
>
> docs/images/maintenance-primitives-modes.png PRE-CREATION
> docs/maintenance.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37585/diff/
>
>
> Testing
> -------
>
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
>
>
> File Attachments
> ----------------
>
> Same as the image in the binary diff. (Uploaded for reviewer convenience.)
> https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 37585: Maintenance primitives: Add a user doc.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/
-----------------------------------------------------------
(Updated Sept. 18, 2015, 12:51 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
Changes
-------
Update json examples to match code changes.
Bugs: MESOS-2083
https://issues.apache.org/jira/browse/MESOS-2083
Repository: mesos
Description
-------
Heavily based on the design doc (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
Includes a diagram of the maintenance mode transitions.
Diffs (updated)
-----
docs/images/maintenance-primitives-modes.png PRE-CREATION
docs/maintenance.md PRE-CREATION
Diff: https://reviews.apache.org/r/37585/diff/
Testing
-------
Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
Checked for markdown correctness.
File Attachments
----------------
Same as the image in the binary diff. (Uploaded for reviewer convenience.)
https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png
Thanks,
Joseph Wu
Re: Review Request 37585: Maintenance primitives: Add a user doc.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/
-----------------------------------------------------------
(Updated Sept. 14, 2015, 2:32 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
Bugs: MESOS-2083
https://issues.apache.org/jira/browse/MESOS-2083
Repository: mesos
Description (updated)
-------
Heavily based on the design doc (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
Includes a diagram of the maintenance mode transitions.
Diffs
-----
docs/images/maintenance-primitives-modes.png PRE-CREATION
docs/maintenance.md PRE-CREATION
Diff: https://reviews.apache.org/r/37585/diff/
Testing
-------
Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
Checked for markdown correctness.
File Attachments
----------------
Same as the image in the binary diff. (Uploaded for reviewer convenience.)
https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png
Thanks,
Joseph Wu
Re: Review Request 37585: Maintenance primitives: Add a user doc.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/
-----------------------------------------------------------
(Updated Sept. 14, 2015, 2:32 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
Changes
-------
One pass through the doc for Artem's comments.
Bugs: MESOS-2083
https://issues.apache.org/jira/browse/MESOS-2083
Repository: mesos
Description
-------
Heavily based on the design doc (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
Includes a diagram of the maintenance mode transitions.
This documents the current working prototype (MVP), which starts here:
https://reviews.apache.org/r/36321/
One TODO remaining: Update with the release version that maintenance primitives will be released in.
Diffs (updated)
-----
docs/images/maintenance-primitives-modes.png PRE-CREATION
docs/maintenance.md PRE-CREATION
Diff: https://reviews.apache.org/r/37585/diff/
Testing
-------
Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
Checked for markdown correctness.
File Attachments
----------------
Same as the image in the binary diff. (Uploaded for reviewer convenience.)
https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png
Thanks,
Joseph Wu
Re: Review Request 37585: Maintenance primitives: Add a user doc.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review97317
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37585]
All tests passed.
- Mesos ReviewBot
On Sept. 1, 2015, 5:42 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 5:42 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
>
>
> Bugs: MESOS-2083
> https://issues.apache.org/jira/browse/MESOS-2083
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Heavily based on the design doc (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
>
> Includes a diagram of the maintenance mode transitions.
>
> This documents the current working prototype (MVP), which starts here:
> https://reviews.apache.org/r/36321/
>
> One TODO remaining: Update with the release version that maintenance primitives will be released in.
>
>
> Diffs
> -----
>
> docs/images/maintenance-primitives-modes.png PRE-CREATION
> docs/maintenance.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37585/diff/
>
>
> Testing
> -------
>
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
>
>
> File Attachments
> ----------------
>
> Same as the image in the binary diff. (Uploaded for reviewer convenience.)
> https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 37585: Maintenance primitives: Add a user doc.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/
-----------------------------------------------------------
(Updated Sept. 1, 2015, 10:42 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
Changes
-------
Updated example JSON and CURL based on current MVP. Updated picture.
Bugs: MESOS-2083
https://issues.apache.org/jira/browse/MESOS-2083
Repository: mesos
Description
-------
Heavily based on the design doc (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
Includes a diagram of the maintenance mode transitions.
This documents the current working prototype (MVP), which starts here:
https://reviews.apache.org/r/36321/
One TODO remaining: Update with the release version that maintenance primitives will be released in.
Diffs (updated)
-----
docs/images/maintenance-primitives-modes.png PRE-CREATION
docs/maintenance.md PRE-CREATION
Diff: https://reviews.apache.org/r/37585/diff/
Testing
-------
Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
Checked for markdown correctness.
File Attachments (updated)
----------------
Same as the image in the binary diff. (Uploaded for reviewer convenience.)
https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png
Thanks,
Joseph Wu
Re: Review Request 37585: Maintenance primitives: Add a user doc.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review97128
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37585]
All tests passed.
- Mesos ReviewBot
On Aug. 31, 2015, 6:11 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2015, 6:11 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
>
>
> Bugs: MESOS-2083
> https://issues.apache.org/jira/browse/MESOS-2083
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Heavily based on the design doc (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
>
> Includes a diagram of the maintenance mode transitions.
>
> This documents the current working prototype (MVP), which starts here:
> https://reviews.apache.org/r/36321/
>
> One TODO remaining: Update with the release version that maintenance primitives will be released in.
>
>
> Diffs
> -----
>
> docs/images/maintenance-primitives-modes.png PRE-CREATION
> docs/maintenance.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37585/diff/
>
>
> Testing
> -------
>
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
>
>
> File Attachments
> ----------------
>
> Same as the image in the binary diff. (Uploaded for reviewer convenience.)
> https://reviews.apache.org/media/uploaded/files/2015/08/31/ce897571-0d3a-4ecb-8d36-a63eff855647__maintenance-primitives-modes.png
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 37585: Maintenance primitives: Add a user doc.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/
-----------------------------------------------------------
(Updated Aug. 31, 2015, 11:11 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
Changes
-------
Addressed comments. Added image file to review for reviewer convenience.
Bugs: MESOS-2083
https://issues.apache.org/jira/browse/MESOS-2083
Repository: mesos
Description
-------
Heavily based on the design doc (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
Includes a diagram of the maintenance mode transitions.
This documents the current working prototype (MVP), which starts here:
https://reviews.apache.org/r/36321/
One TODO remaining: Update with the release version that maintenance primitives will be released in.
Diffs (updated)
-----
docs/images/maintenance-primitives-modes.png PRE-CREATION
docs/maintenance.md PRE-CREATION
Diff: https://reviews.apache.org/r/37585/diff/
Testing
-------
Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
Checked for markdown correctness.
File Attachments (updated)
----------------
Same as the image in the binary diff. (Uploaded for reviewer convenience.)
https://reviews.apache.org/media/uploaded/files/2015/08/31/ce897571-0d3a-4ecb-8d36-a63eff855647__maintenance-primitives-modes.png
Thanks,
Joseph Wu
Re: Review Request 37585: Maintenance primitives: Add a user doc.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review96509
-----------------------------------------------------------
docs/maintenance.md (line 147)
<https://reviews.apache.org/r/37585/#comment151937>
Can we merge 147 - 149 and 152 - 153 together?
docs/maintenance.md (line 165)
<https://reviews.apache.org/r/37585/#comment151944>
s/emminently/eminently
- Guangya Liu
On Aug. 25, 2015, 12:59 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 12:59 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
>
>
> Bugs: MESOS-2083
> https://issues.apache.org/jira/browse/MESOS-2083
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Heavily based on the design doc (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
>
> Includes a diagram of the maintenance mode transitions.
>
> This documents the current working prototype (MVP), which starts here:
> https://reviews.apache.org/r/36321/
>
> One TODO remaining: Update with the release version that maintenance primitives will be released in.
>
>
> Diffs
> -----
>
> docs/images/maintenance-primitives-modes.png PRE-CREATION
> docs/maintenance.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37585/diff/
>
>
> Testing
> -------
>
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 37585: Maintenance primitives: Add a user doc.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review96520
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37585]
All tests passed.
- Mesos ReviewBot
On Aug. 25, 2015, 12:59 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 12:59 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
>
>
> Bugs: MESOS-2083
> https://issues.apache.org/jira/browse/MESOS-2083
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Heavily based on the design doc (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
>
> Includes a diagram of the maintenance mode transitions.
>
> This documents the current working prototype (MVP), which starts here:
> https://reviews.apache.org/r/36321/
>
> One TODO remaining: Update with the release version that maintenance primitives will be released in.
>
>
> Diffs
> -----
>
> docs/images/maintenance-primitives-modes.png PRE-CREATION
> docs/maintenance.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37585/diff/
>
>
> Testing
> -------
>
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 37585: Maintenance primitives: Add a user doc.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/
-----------------------------------------------------------
(Updated Aug. 24, 2015, 5:59 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
Changes
-------
Updated with a binary patch.
Bugs: MESOS-2083
https://issues.apache.org/jira/browse/MESOS-2083
Repository: mesos
Description
-------
Heavily based on the design doc (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
Includes a diagram of the maintenance mode transitions.
This documents the current working prototype (MVP), which starts here:
https://reviews.apache.org/r/36321/
One TODO remaining: Update with the release version that maintenance primitives will be released in.
Diffs (updated)
-----
docs/images/maintenance-primitives-modes.png PRE-CREATION
docs/maintenance.md PRE-CREATION
Diff: https://reviews.apache.org/r/37585/diff/
Testing
-------
Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
Checked for markdown correctness.
Thanks,
Joseph Wu
Re: Review Request 37585: Maintenance primitives: Add a user doc.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review96251
-----------------------------------------------------------
Bad patch!
Reviews applied: [37585]
Failed command: ./support/apply-review.sh -n -r 37585
Error:
2015-08-25 00:20:09 URL:https://reviews.apache.org/r/37585/diff/raw/ [12769/12769] -> "37585.patch" [1]
error: missing binary patch data for 'docs/images/maintenance-primitives-modes.png'
error: binary patch does not apply to 'docs/images/maintenance-primitives-modes.png'
error: docs/images/maintenance-primitives-modes.png: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Aug. 24, 2015, 9:14 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2015, 9:14 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
>
>
> Bugs: MESOS-2083
> https://issues.apache.org/jira/browse/MESOS-2083
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Heavily based on the design doc (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
>
> Includes a diagram of the maintenance mode transitions.
>
> This documents the current working prototype (MVP), which starts here:
> https://reviews.apache.org/r/36321/
>
> One TODO remaining: Update with the release version that maintenance primitives will be released in.
>
>
> Diffs
> -----
>
> docs/images/maintenance-primitives-modes.png PRE-CREATION
> docs/maintenance.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37585/diff/
>
>
> Testing
> -------
>
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 37585: Maintenance primitives: Add a user doc.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/
-----------------------------------------------------------
(Updated Aug. 24, 2015, 2:14 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
Changes
-------
Add a sentence under Scheduling Maintenance -> Important Note; to describe what happens when a machine has multiple IPs/hostnames.
Bugs: MESOS-2083
https://issues.apache.org/jira/browse/MESOS-2083
Repository: mesos
Description
-------
Heavily based on the design doc (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
Includes a diagram of the maintenance mode transitions.
This documents the current working prototype (MVP), which starts here:
https://reviews.apache.org/r/36321/
One TODO remaining: Update with the release version that maintenance primitives will be released in.
Diffs (updated)
-----
docs/images/maintenance-primitives-modes.png PRE-CREATION
docs/maintenance.md PRE-CREATION
Diff: https://reviews.apache.org/r/37585/diff/
Testing
-------
Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
Checked for markdown correctness.
Thanks,
Joseph Wu