[GitHub] spark pull request #18515: [SPARK-21287][SQL] Ability to use Integer.MIN_VAL...

[gatorsmile <gi...@git.apache.org>]

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18515#discussion_r125328090
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala ---
    @@ -103,10 +103,11 @@ class JDBCOptions(
           s" and '$JDBC_NUM_PARTITIONS' are required.")
       val fetchSize = {
         val size = parameters.getOrElse(JDBC_BATCH_FETCH_SIZE, "0").toInt
    -    require(size >= 0,
    +    require(size >= 0 || size == Integer.MIN_VALUE,
    --- End diff --
    
    It does not make sense to the other data sources except MySQL. If needed, we can introduce a dialect specific checking APIs in [JdbcDialect.scala](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org